Fix duplicate component codes#75
Merged
davecramer merged 1 commit intopostgresql-interfaces:mainfrom Jan 20, 2025
Merged
Conversation
The autogenerated component GUIDs were based on the same path and therefore were the same in both bitnesses. Installing both worked, but once one of them was uninstalled, the other's files remained despite its uninstallation finishing successfully. I have no idea how this got through my testing; perhaps it only happens when both merge modules are installed via the same MSI.
Contributor
|
@chrullrich is this still relevant ? |
Contributor
Author
|
Yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autogenerated component GUIDs were based on the same path and therefore were the same in both bitnesses. Installing both worked, but once one of them was uninstalled, the other's files remained despite its uninstallation finishing successfully.
I have no idea how this got through my testing; perhaps it only happens when both merge modules are installed via the same MSI.