cmake: Don't force Release build. Fixes -DCMAKE_RELAEASE_TYPE not working #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king. That made packaging and debugging hell for distros and users, see e.g. potree#450 (comment) Also fix that `Converter/libs/brotli/CMakeLists.txt` overrode the build type globally again. Note that there seems to be no global consensus on how to just set the default bulid type in CMake: * https://cmake.org/pipermail/cmake/2008-September/023808.html * https://stackoverflow.com/questions/23907679/cmake-ignores-d-cmake-build-type-debug * https://blog.kitware.com/cmake-and-the-default-build-type/ * https://stackoverflow.com/questions/48832233/have-a-cmake-project-default-to-the-release-build-type So this commit arbitrarily chooses one way that at least isn't absolutely wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That made packaging and debugging hell for distros and users, see e.g. #450 (comment)
Also fix that
Converter/libs/brotli/CMakeLists.txtoverrode the build type globally again.Note that there seems to be no global consensus on how to just set the default bulid type in CMake:
So this commit arbitrarily chooses one way that at least isn't absolutely wrong.