Fix writeFile silently continuing on errors. #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if the disk is full, it would write `metadata.json` as an empty file, and then later fail with a JSON parse error on the same file. Also implement good error messages using C, which `<iostream>` cannot do. For example, the above case would probably produce `metadata.json: No space left on device`.
nh2
force-pushed
the
writeFile-error-handling
branch
from
f7e9710 to
473d106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if the disk is full, it would write
metadata.jsonas an empty file, and then later fail with a JSON parse error on the same file.Also implement good error messages using C, which
<iostream>cannot do. For example, the above case would probably producemetadata.json: No space left on device.Please check that it works well on Windows, too. I only tried it on Linux.