Skip to content

Conversation

@nh2
Copy link

@nh2 nh2 commented Jan 13, 2025

Fixes #550.

@nh2
Copy link
Author

nh2 commented Jan 13, 2025

Note that while this fixes the segfault, on one of my datasets that previously crashed I now got out-of-memory. I don't know if that is explained by the extra vector entries that are now allowed.

For another, 20x larger dataset las files of total of > 2000 GB, it did not crash nor OOM, so I wonder in which case this code path is even triggered.

I don't fully understand the meaning/purpose of dbgAccepted yet; unfortunately the code has no comments that explain what is done and why.

@nh2 nh2 force-pushed the issue-550-fix-sampler-segfault branch from ee8520d to 0a07493 Compare March 28, 2025 14:15
@nh2
Copy link
Author

nh2 commented Mar 28, 2025

I don't fully understand the meaning/purpose of dbgAccepted yet; unfortunately the code has no comments that explain what is done and why.

I now understood it after reading the PotreeConverter paper at https://www.cg.tuwien.ac.at/research/publications/2020/SCHUETZ-2020-MPC/SCHUETZ-2020-MPC-paper.pdf

while this fixes the segfault, on one of my datasets that previously crashed I now got out-of-memory

It was because of my change. I didn't notice the thread_local qualifier on the dbgAccepted vector.

I've pushed a fix to this overuse of memory my PR introduced so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault in SamplerPoisson::sample

1 participant