Fix incorrect offset calculation when writing extra attributes to output buffer #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When writing extra attributes from LAS files to the output buffer, the code incorrectly uses attributeOffset (which tracks the input attribute positions) instead of
targetOffset (which represents the correct output buffer offset).
This causes extra attributes to be written to wrong memory locations in the output buffer, resulting in corrupted point cloud data when the input and output attribute layouts
differ.
Root Cause:
In chunker_countsort_laszip.cpp, the lambda capture and memcpy operation use attributeOffset:
auto handleAttribute = [data, point, header, attributeSize, attributeOffset, sourceOffset, attribute](int64_t offset) {
memcpy(data + offset + attributeOffset, point->extra_bytes + sourceOffset, attributeSize);
However, targetOffset is already correctly calculated on line 582 using outputAttributes.getOffset() but was never used.
Fix:
Replace attributeOffset with targetOffset in the lambda capture and memcpy call:
auto handleAttribute = [data, point, header, attributeSize, targetOffset, sourceOffset, attribute](int64_t offset) {
memcpy(data + offset + targetOffset, point->extra_bytes + sourceOffset, attributeSize);