Structured load api moretests#28
Merged
pp-mo merged 4 commits intostructured_load_apifrom Nov 10, 2016
Merged
Conversation
|
Hi @pp-mo i am a bit wary about the use of mixins here and the potential complication it can add. I think it is worth some thought about what is trying to be achieved here and how to deliver it effectively. we have been burnt in the past by complicated code sharing across tests and I think we should be a little wary of making it to hard to see the code that a single test is running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A whole lot more testing.
Targetted against branch "structured_load_api" -- which could now be treated like a "feature branch" ??
Almost completed my wishlist for tests now.
One thing we might still add : A test to cover the current undesirable behaviour of multiple orography fields, which tend convert as a time-dependent surface_altitude coordinate. I think this can also cause a rules failure where a factory does not get produced (but did not fail not in all cases ?)