set_active_channels: ','.join() channel lists before _finish() #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerox1101
pushed a commit
to xerox1101/python-saleae
that referenced
this pull request
Aug 12, 2016
Using type(list) doesn't work for all possible types and isinstance() is a safer way to check this. This was happening with Python 2.7.10 when passing a list of specific digital channels to the _build() routine in export_data2() but could also happen in other places in the code.
Owner
|
Looks like there are some whitespace issues with your PR: https://travis-ci.org/ppannuto/python-saleae/jobs/151665617#L330 Also, I don't think this change is correct / necessary. The After your change: Note that this function is only supported by Logic 16, Logic 8(2nd gen), Logic Pro 8, and Logic Pro 16. If you just start up an instance of Logic with no Saleae attached, the virtual Saleae it creates doesn't support this function and the command will be NAK'd. Feel free to re-open this PR if I missed something and you've fixed the whitespace issues. |
ppannuto
added a commit
that referenced
this pull request
Aug 16, 2016
Issue #23: Fix a problem building strings from lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: Issue #22
_finish() joins the built list before sending to Logic via _cmd()
'set_active_channels' calls _build() on a list object, and therefore fails the join.
I have fixed this issue by joining the channel list before passing to _build. Seems to work fine for me now.