Additional investigations of the export process #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made an additional investigation of the export process and here is my results. The main conclusion is - we should take into account what channels are **Active** and what channels are asked to **Export**. Only this way we can choose the right combination of options. NOTE: Tested only on my Saleae Logic Pro 8 with 1.2.12 software version. ## `export_data2()` results relative to enabled and exported channels | Enabled channels | Exported channels | Correct command | | ---------------- | ----------------- | ---------------------------------------- | | Analog | Analog | ' ' (None) | | | Digital | Wrong combination | | | Both | Wrong combination | | | | | | Digital | Analog | Wrong combination | | | Digital | ' ' (None) | | | Both | Wrong combination | | | | | | Both | Analog | ANALOG_ONLY (ANALOG_AND_DIGITAL also works) | | | Digital | DIGITAL_ONLY | | | Both | ANALOG_AND_DIGITAL | ## Examples **Analog** enabled and **analog** exported: ```python s.set_active_channels([], [2, 3]) s.export_data2(filename, digital_channels=None, analog_channels=[3]) ``` **Digital** enabled and **digital** exported: ```python s.set_active_channels([0, 1], []) s.export_data2(filename, digital_channels=[0], analog_channels=None) ``` **Both** enabled ```python s.set_active_channels([0, 1], [2, 3]) ``` and: - **analog** exported: ```python s.export_data2(filename, digital_channels=None, analog_channels=[3]) ``` - **digital** exported: ```python s.export_data2(filename, digital_channels=[0], analog_channels=None) ``` - **both** exported ``` python s.export_data2(filename, digital_channels=[0], analog_channels=[3]) ```
Owner
|
Nice work! Thanks for going through the effort to enumerate all of these cases |
ppannuto
added a commit
that referenced
this pull request
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an additional investigation of the export process and here is my results. The main conclusion is - we should take into account what channels are Active and what channels are asked to Export. Only this way we can choose the right combination of options.
NOTE: Tested only on my Saleae Logic Pro 8 with 1.2.12 software version.
export_data2()results relative to enabled and exported channelsExamples
Analog enabled and analog exported:
Digital enabled and digital exported:
Both enabled
and:
analog exported:
digital exported:
both exported