WIP: Ignore provided 'region' if 'credentialScope' is defined#258
Open
meis wants to merge 2 commits intopplu:release/0.39from
Open
WIP: Ignore provided 'region' if 'credentialScope' is defined#258meis wants to merge 2 commits intopplu:release/0.39from
meis wants to merge 2 commits intopplu:release/0.39from
Conversation
If we end in a rule with 'credentialScope', we probably want to ignore the 'region' even if the user has defined one. Request to rules with 'credentialScope' are only going to succeed with the region in it, so if the user (mistakenly or not) has a 'region' defined the request will fail. It may be nice, though, to leave a WARNING if 'region' is defined and is different from the one in 'credentialScope'.
Owner
|
Hi, I've imported the branch so travis runs the full test suite: it looks like the code was there to let the user specify with what region to sign when a custom endpoint is specified. |
meis
changed the title
Contributor
Author
|
I've added a new commit that AFAIK greens everything again. I'm not really sure if you want to do this, tho. I don't like the hacky approach but I'm really not familiar with the codebase to come up with a better solution. Maybe it's a problem we don't need to solve. Give it a glance and maybe we can discuss it at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we end in a rule with 'credentialScope', we probably want to ignore
the 'region' even if the user has defined one.
Request to rules with 'credentialScope' are only going to succeed with
the region in it, so if the user (mistakenly or not) has a 'region'
defined the request will fail.
It may be nice, though, to leave a WARNING if 'region' is defined and is
different from the one in 'credentialScope'.