Skip to content

Remove NativeLibraryLoader#68

Merged
peppy merged 2 commits intoppy:masterfrom
smoogipoo:remove-nll
Aug 24, 2025
Merged

Remove NativeLibraryLoader#68
peppy merged 2 commits intoppy:masterfrom
smoogipoo:remove-nll

Conversation

@smoogipoo
Copy link
Copy Markdown

No description provided.

@smoogipoo
Copy link
Copy Markdown
Author

smoogipoo commented Aug 24, 2025

I've tested this on macOS (the only affected platforms, we don't use GL on macOS/iOS) in combination with ppy/veldrid-spirv#12 (with a fixed package reference), and I think this is good to go now.

@smoogipoo smoogipoo marked this pull request as ready for review August 24, 2025 11:22
@smoogipoo
Copy link
Copy Markdown
Author

smoogipoo commented Aug 24, 2025

Benchmarks (git clean -xdf && dotnet build osu-framework.Desktop.slnf):

Run master remove-nll
1 7.58 8.34
2 6.77 6.36
3 8.84 6.25
4 7.91 7.41
5 6.59 6.03
6 7.65 7.47
7 6.43 6.97
8 8.21 6.86
9 7.29 7.65
10 6.64 6.22
     
Mean 7.391 6.956
Median 7.435 6.915
Std. Dev 0.7935496904 0.7549569524

GenerateDepsFile (top-10 most expensive tasks) goes from 3.7s to 2.6s

@smoogipoo smoogipoo requested a review from peppy August 24, 2025 11:39
@peppy peppy merged commit a405fe8 into ppy:master Aug 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants