Conversation
| && pip install --no-cache-dir --upgrade --force-reinstall "pip==$PYTHON_PIP_VERSION" \ | ||
| # then we use "pip list" to ensure we don't have more than one pip version installed | ||
| # https://github.com/docker-library/python/pull/100 | ||
| && [ "$(pip list |tac|tac| awk -F '[ ()]+' '$1 == "pip" { print $2; exit }')" = "$PYTHON_PIP_VERSION" ] \ |
There was a problem hiding this comment.
Are comments between line-continuations legal in dockerfiles? I know they don't work in bash and various other places. (The first line of the comment is seen as the continued line and then whatever comes afterwards is seen as a new line.)
There was a problem hiding this comment.
It seems they are...
Last I checked the Dockerfile parser was very simplistic (although it seems to have got slightly fancier in 1.12). It basically just checks for a # at the start of a line (the only kind of supported comment) and ignores that line.
There was a problem hiding this comment.
Most things only do the comment ignoring after joining up continued lines or something. If you've tested that this works I'm happy with it, though.
|
👍 |
2 participants
docker-library/python#144: