Fixed DeserializationException + improved unit testing#21
Fixed DeserializationException + improved unit testing#2193Omar wants to merge 9 commits intoprajjwaldimri:masterfrom
Conversation
Fixed deserialization issue in GetSongs + improved unit testing
|
Can you set your indentation level to 2 spaces instead of 4? That's the convention I follow. Thanks :) |
|
@prajjwaldimri done. |
|
@OmarPani93 Should I merge this? |
|
@prajjwaldimri if you want you could merge it already. |
|
@OmarPani93 Alright. We'll merge it when you complete your tests. |
|
@OmarPani93 Any updates on the tests? |
|
Hi @prajjwaldimri, sorry for the delay. I have been busy recently. Hopefully I will do the tests in the next couple of weeks. Sorry again. |
|
Hey Omar. No worries. :) Looking forward to merging your changes in the repo. |
Fixes #20
There are a lot of changes but most of them are related to code indentation performed by CTRL + K, CTRL + D shortcut on Visual Studio so don't worry.
I added more tests in order to be sure I didn't break other functionalities. You can run them, if you want, after putting the API key in the App.config file.