Skip to content

test(ct): component features#5

Merged
JoviDeCroock merged 1 commit intopreactjs:mainfrom
sand4rt:component-tests
Dec 29, 2022
Merged

test(ct): component features#5
JoviDeCroock merged 1 commit intopreactjs:mainfrom
sand4rt:component-tests

Conversation

@sand4rt
Copy link
Copy Markdown

@sand4rt sand4rt commented Dec 29, 2022

Current version seems to work quite well already!:) Applied of most React's test suite: https://github.com/microsoft/playwright/blob/main/tests/components/ct-react-vite/src/tests.spec.tsx

Only the beforeMount and afterMount hooks are missing: microsoft/playwright#18616. Shall i take a look at that?

Maybe we can change the project structure to that of Playwright? With a separate adapter project:
https://github.com/microsoft/playwright/tree/main/packages/playwright-ct-react

And a separate test project:
https://github.com/microsoft/playwright/blob/main/tests/components/ct-react-vite

Copy link
Copy Markdown
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If splitting it up is easier for compatibility I am all for it, what advantages does this bring if I may ask?

Tests are amazing, thank you!

@JoviDeCroock JoviDeCroock merged commit e0e7354 into preactjs:main Dec 29, 2022
@sand4rt
Copy link
Copy Markdown
Author

sand4rt commented Dec 30, 2022

@JoviDeCroock

Then it's easier to integrate it into Playwright's repository. Perhaps we should create an issue first to ask if they are ready or if we have to wait a little longer? All features match with Playwright's features, so IMO it's about time. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants