test(ct): component features#5
Merged
JoviDeCroock merged 1 commit intopreactjs:mainfrom Dec 29, 2022
Merged
Conversation
JoviDeCroock
approved these changes
Dec 29, 2022
Author
|
Then it's easier to integrate it into Playwright's repository. Perhaps we should create an issue first to ask if they are ready or if we have to wait a little longer? All features match with Playwright's features, so IMO it's about time. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version seems to work quite well already!:) Applied of most React's test suite: https://github.com/microsoft/playwright/blob/main/tests/components/ct-react-vite/src/tests.spec.tsx
Only the
beforeMountandafterMounthooks are missing: microsoft/playwright#18616. Shall i take a look at that?Maybe we can change the project structure to that of Playwright? With a separate adapter project:
https://github.com/microsoft/playwright/tree/main/packages/playwright-ct-react
And a separate test project:
https://github.com/microsoft/playwright/blob/main/tests/components/ct-react-vite