Avoid file locks + overwrites by using a temp file for HTML templates #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would solve our problems of developers and gitlab CI running preact-cli on the same server. |
rschristian
force-pushed
the
avoid-file-locks
branch
from
044dad6 to
0887318
Compare
🦋 Changeset detectedLatest commit: dfc52af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
reviewed
Dec 24, 2022
Comment on lines
+48
to
+51
| const tmpDir = join( | ||
| os.tmpdir(), | ||
| `preact-cli-${Math.floor(Math.random() * 100000)}` | ||
| ); |
Member
There was a problem hiding this comment.
I think tempy is rather overkill for our needs, especially with the number of dependencies it adds: http://npm.anvaka.com/#/view/2d/tempy
A random number between 0 and 100,000 should be sufficient enough to avoid conflicts I think.
Merged
This was referenced Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1331.
Note: I just made this edit quickly, need to install tempy and update the package lock.