Skip to content

Schain module: do not share schain objects across different bid requests #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patmmccann merged 1 commit into from
Jun 1, 2023
Merged

Schain module: do not share schain objects across different bid requests #10021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/schain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
isInteger,
_each,
logWarn,
deepAccess, deepSetValue
deepAccess, deepSetValue, deepClone
} from '../src/utils.js';
import {registerOrtbProcessor, REQUEST} from '../src/pbjsORTB.js';

Expand Down Expand Up @@ -180,7 +180,7 @@ export function makeBidRequestsHook(fn, bidderRequests) {
bidderRequest.bids.forEach(bid => {
let result = resolveSchainConfig(schainConfig, bidder);
if (result) {
bid.schain = result;
bid.schain = deepClone(result);
}
});
});
Expand Down
9 changes: 9 additions & 0 deletions test/spec/modules/schain_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,15 @@ describe('#makeBidRequestsHook', function() {
makeBidRequestsHook(testCallback, testBidderRequests);
});

it('should not share the same schain object between different bid requests', (done) => {
config.setBidderConfig(goodStrictBidderConfig);
makeBidRequestsHook((requests) => {
requests[0].bids[0].schain.field = 'value';
expect(requests[1].bids[0].schain.field).to.not.exist;
done();
}, deepClone(bidderRequests))
});

it('should reject bad strict config but allow a bad relaxed config for bidders trying to override it', function () {
function testCallback(bidderRequests) {
expect(bidderRequests[0].bids[0].schain).to.exist;
Expand Down