Skip to content

Rubicon Bid Adapter: Format rubicon EID#10409

Merged
ChrisHuie merged 2 commits intomasterfrom
rubicon-rubiEidsHandler
Aug 30, 2023
Merged

Rubicon Bid Adapter: Format rubicon EID#10409
ChrisHuie merged 2 commits intomasterfrom
rubicon-rubiEidsHandler

Conversation

@robertrmartinez
Copy link
Collaborator

Type of change

  • Other

Description of change

rubiconproject.com eids are coming with the default ^${atype} appended to the id value, new requirements state for this specific one we should drop it!

expect(data['eid_catchall']).to.equal('11111^2');
});

it('should send rubiconproejct special case', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my strong suit!

fixed.

Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie self-assigned this Aug 30, 2023
@ChrisHuie ChrisHuie merged commit 7709898 into master Aug 30, 2023
@ChrisHuie ChrisHuie deleted the rubicon-rubiEidsHandler branch August 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments