ttd Bid Adapter: use bidderRequestId instead of auctionId#10411
Merged
patmmccann merged 1 commit intoprebid:masterfrom Aug 31, 2023
Merged
Conversation
Contributor
Author
|
Just to confirm unlike |
khang-vu-ttd
changed the title
patmmccann
approved these changes
Aug 31, 2023
Collaborator
|
That's correct, not sure how I missed this, good catch |
khang-vu-ttd
deleted the
kvu-OPATH-1131-dont-use-transactionid-for-bidid
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Does this change affect user-facing APIs or examples documented on http://prebid.org?
No
Description of change
Notice that ttd adapter is using
bidderRequest.auctionIdinstead ofbidderRequest.bidderRequestId.Looking at df66cdb it seems like it should be
bidderRequest.bidderRequestIdOther information