Media Filter RTD Provider : initial modul release#10418
Merged
patmmccann merged 9 commits intoprebid:masterfrom Nov 14, 2023
Merged
Media Filter RTD Provider : initial modul release#10418patmmccann merged 9 commits intoprebid:masterfrom
patmmccann merged 9 commits intoprebid:masterfrom
Conversation
Contributor
Author
|
Is there something I can do to help push this PR forward? (not sure if this is blocked by me?) |
spotxslagle
approved these changes
Oct 5, 2023
Contributor
spotxslagle
left a comment
There was a problem hiding this comment.
I left a comment on something I didn't understand, but it works either way, so LGTM
mcajlakovic
commented
Oct 6, 2023
Contributor
Author
mcajlakovic
left a comment
There was a problem hiding this comment.
Reviewed and responded to comments
Contributor
Author
|
Hi @ChrisHuie, is there something I can do to help push this PR forward? Are we missing anything on our end? |
Contributor
Author
|
@ChrisHuie LGTM, are there any next steps for release? |
Contributor
Contributor
Author
Collaborator
|
Needs changes to submodules.json |
patmmccann
reviewed
Nov 6, 2023
Contributor
Author
|
mcajlakovic
commented
Nov 13, 2023
Contributor
Author
mcajlakovic
left a comment
There was a problem hiding this comment.
updated adloader.js and .submodules.json
Contributor
Author
|
Thank you for your help on getting this pr merged! @spotxslagle @patmmccann |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added The Media Filter RTD Provider module
For more information about The Media Filter, please see https://mediatrust.com/how-we-help/media-filter