Merged
Conversation
Collaborator
nickjacob
commented
Nov 23, 2015
nickjacob
commented
- added adapter back from previous version
- fixed/normalized indentation
- made sizeId & alias optional
nickjacob
force-pushed
the
aol-dac-adapter
branch
from
dae3ed6 to
856a659
Compare
nickjacob
force-pushed
the
aol-dac-adapter
branch
from
856a659 to
ebc91ae
Compare
|
In fact there is no reason to use DAC.js for AOL at all. You can just send properly formatted HTTP GET requests to their endpoint and receive the bids back as OpenRTB JSON objects. Much simpler this way, in my opinion. |
Collaborator
|
Thanks @jononomo! We in fact had 2 adaptors, one with DAC one without. AOL recommended the DAC adaptor as that's what they're maintaining today. We want to make sure publishers have good support from the bidder through the project. Thanks for letting us know! |
Contributor
|
Thanks again @nickjacob & @ikhemissi for collaborating on this. |
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 6, 2017
….25.0 to aolgithub-master * commit '2a31c81b71595988ed2bf3470fb94d4fb75098bc': (71 commits) Sync with contrib/aol-adapter-aliases branch. Added junit reporter, improved browserstack tests running. Change browsers config to allow run tests on CI. Temporary comment unit test to provide compatibility with pre-bidder timeout feature. Added banner for minified source file. Improve matching to avoid breaking js syntax. Changed changelog entry. Fixed invalid module link. Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Added changelog entry. Added ids in aolPartnersIds. Added tests for delimiterLoader. Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Improved adapter source code wrappig. Changed aol analytics adapter to new structure. Get rid of preserve keyword. Added preserved keyword for adapters wrapping. ...
github-baptiste-haudegand
added a commit
to ebuzzing/Prebid.js
that referenced
this pull request
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.