create adapter adyoulike by jbAdyoulike · Pull Request #1155 · prebid/Prebid.js

jbAdyoulike · 2017-04-25T15:56:24Z

Type of change

Description of change

test parameters for validating bids

{
  bidder: 'adyoulike',
  params: {
     placement: "194f787b85c829fb8822cdaf1ae64435",
  }
}

-dev-ssp@adyoulike.com

official adapter submission

Other information

dbemiller · 2017-05-02T15:41:45Z

src/adapters/adyoulike.js

Keeping state out here will be buggy. What would happen if callBids gets called twice before your ajax request returns? For example, suppose a page makes more than one cal to requestBids.

You can make it safe if you use newResponseHandler(requests) as your ajax callback (where newResponseHandler(requests) returns the handleResponse function, with the requests stored in the closure scope)

dbemiller · 2017-05-02T16:04:00Z

You'll also want to submit a documentation PR for the bidder params page.

dbemiller · 2017-05-02T16:06:00Z

I'm seeing CORS errors when testing:

XMLHttpRequest cannot load http://hb-api.omnitagjs.com/hb-api/prebid?. Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. Origin 'http://test.localhost:9999' is therefore not allowed access. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.

My test page is below:

<html>
<head>
    <!-- Prebid Config Section START -->
    <!-- Make sure this is inserted before your GPT tag -->
    <script>
      var PREBID_TIMEOUT = 700;

      var adUnits = [{
        code: 'div-gpt-ad-1460505748561-0',
        sizes: [[300, 250], [300,600]],
        bids: [{
          bidder: 'adyoulike',
          params: {
            placement: "d135a2027b1041059f06fbf8cf4ddfef",
          }
        }]
      }];

      var pbjs = pbjs || {};
      pbjs.que = pbjs.que || [];

    </script>
    <!-- Prebid Config Section END -->

    <!-- Prebid Boilerplate Section START. No Need to Edit. -->
    <script type="text/javascript" src="../build/dev/prebid.js" async></script>
    <script>
      var googletag = googletag || {};
      googletag.cmd = googletag.cmd || [];
      googletag.cmd.push(function() {
        googletag.pubads().disableInitialLoad();
      });

      pbjs.que.push(function() {
        pbjs.addAdUnits(adUnits);
        pbjs.requestBids({
          bidsBackHandler: sendAdserverRequest
        });
      });

      function sendAdserverRequest() {
        if (pbjs.adserverRequestSent) return;
        pbjs.adserverRequestSent = true;
        googletag.cmd.push(function() {
          pbjs.que.push(function() {
            pbjs.setTargetingForGPTAsync();
            googletag.pubads().refresh();
          });
        });
      }

      setTimeout(function() {
        sendAdserverRequest();
      }, PREBID_TIMEOUT);

    </script>
    <!-- Prebid Boilerplate Section END -->

    <script>
      (function () {
        var gads = document.createElement('script');
        gads.async = true;
        gads.type = 'text/javascript';
        var useSSL = 'https:' == document.location.protocol;
        gads.src = (useSSL ? 'https:' : 'http:') +
          '//www.googletagservices.com/tag/js/gpt.js';
        var node = document.getElementsByTagName('script')[0];
        node.parentNode.insertBefore(gads, node);
      })();
    </script>

    <script>
      googletag.cmd.push(function () {
        googletag.defineSlot('/19968336/header-bid-tag-0', [[300, 250], [300, 600]], 'div-gpt-ad-1460505748561-0').addService(googletag.pubads());

        googletag.pubads().enableSingleRequest();
        googletag.enableServices();
      });
    </script>
</head>

<body>
<h2>Prebid.js Test</h2>
<h5>Div-1</h5>
<div id='div-gpt-ad-1460505748561-0'>
    <script type='text/javascript'>
      googletag.cmd.push(function() { googletag.display('div-gpt-ad-1460505748561-0'); });
    </script>
</div>
</body>
</html>

jbAdyoulike · 2017-05-19T14:28:24Z

Could you use this placement ID for your test: 194f787b85c829fb8822cdaf1ae64435 ?

dbemiller · 2017-05-19T14:53:03Z

@jbAdyoulike please fix the linting errors. eslint --fix might help

jbAdyoulike · 2017-05-19T15:33:08Z

@dbemiller done

dbemiller · 2017-05-19T19:56:27Z

Am seeing errors using that placement Id:

Request params:

      var adUnits = [{
        code: 'div-gpt-ad-1460505748561-0',
        sizes: [[300, 250], [300,600]],
        bids: [{
          bidder: 'adyoulike',
          params: {
            placement: "194f787b85c829fb8822cdaf1ae64435",
          }
        }]
      }];

jbAdyoulike · 2017-05-22T07:33:45Z

@dbemiller Could you give me the request body and response body of this endpoint http://hb-api.omnitagjs.com/hb-api/prebid from the network console to let me investigate on my side ?

This error looks strange, Following what I have from my side :

dbemiller · 2017-05-22T13:46:01Z

jbAdyoulike · 2017-05-23T07:29:56Z

@dbemiller Ok, It was a misconfiguration on my placement, it should works now.

dbemiller · 2017-05-23T13:31:46Z

src/adapters/adyoulike.js

+    try {
+      return window.top.document.referrer;
+    } catch (e) { }
+    return document.referrer;


Generally, it's considered bad practice to use try/catch for control flow: https://softwareengineering.stackexchange.com/a/189225

This can be written linearly by testing for undefined (the same goes for getCanonicalUrl).

dbemiller · 2017-05-23T13:35:10Z

src/adapters/adyoulike.js

+
+  /* Get current page canonical url */
+  function getCanonicalUrl() {
+    if (utils.inIframes) {


This is undefined... did you mean to call utils.inIframe() here?

dbemiller · 2017-05-23T13:38:17Z

Needs just a few changes as far as I can tell... but I do want to complement you especially for writing such pretty code :). Super clear and easy to read.

jbAdyoulike · 2017-05-24T11:36:24Z

@dbemiller It's a pleasure ;)

I have created the PR for the bidder params page prebid/prebid.github.io#252

jaiminpanchal27

LGTM

* create adapter adyoulike * move bidRequests in callBids scope * update adyoulike.js and adyoulike_spec.js syntax * refactor getReferrerUrl and getCanonicalUrl

ayl-julien · 2017-07-25T22:42:44Z

Hi @protonate what do we have to do to have our name updated on prebid.org?

dbemiller · 2017-07-26T12:40:02Z

@ayl-julien @protonate is away for a little while, but submit a PR against this repo to change it.

protonate requested a review from dbemiller April 28, 2017 17:13

protonate assigned dbemiller Apr 28, 2017

dbemiller suggested changes May 2, 2017

View reviewed changes

protonate added the needs update label May 2, 2017

dbemiller mentioned this pull request May 5, 2017

Integration test page for adapters #1182

Merged

1 task

jbAdyoulike force-pushed the master branch from 43a7bdc to f411ef6 Compare May 19, 2017 14:48

jbAdyoulike force-pushed the master branch from f411ef6 to 7d63785 Compare May 19, 2017 14:54

jbAdyoulike added 2 commits May 19, 2017 17:21

create adapter adyoulike

0fa2517

move bidRequests in callBids scope

34f3c28

jbAdyoulike force-pushed the master branch from 7d63785 to 34f3c28 Compare May 19, 2017 15:21

update adyoulike.js and adyoulike_spec.js syntax

d8794cc

dbemiller added needs review and removed needs update labels May 19, 2017

dbemiller reviewed May 23, 2017

View reviewed changes

dbemiller added needs update and removed needs review labels May 23, 2017

refactor getReferrerUrl and getCanonicalUrl

2f40b60

jbAdyoulike mentioned this pull request May 24, 2017

Add Adyoulike adapter prebid/prebid.github.io#252

Merged

dbemiller approved these changes May 24, 2017

View reviewed changes

dbemiller added LGTM and removed needs update labels May 24, 2017

protonate added this to the Prebid 0.25.0 milestone Jun 2, 2017

jaiminpanchal27 approved these changes Jun 5, 2017

View reviewed changes

jaiminpanchal27 merged commit 6b36d64 into prebid:master Jun 5, 2017

protonate pushed a commit that referenced this pull request Jun 7, 2017

create adapter adyoulike (#1155)

67540e4

* create adapter adyoulike * move bidRequests in callBids scope * update adyoulike.js and adyoulike_spec.js syntax * refactor getReferrerUrl and getCanonicalUrl

jbAdyoulike mentioned this pull request Jul 17, 2017

Add Adyoulike adapter prebid/prebid.github.io#298

Merged

Conversation

jbAdyoulike commented Apr 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

dbemiller May 2, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller commented May 2, 2017

Uh oh!

dbemiller commented May 2, 2017

Uh oh!

jbAdyoulike commented May 19, 2017

Uh oh!

dbemiller commented May 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbAdyoulike commented May 19, 2017

Uh oh!

dbemiller commented May 19, 2017

Uh oh!

jbAdyoulike commented May 22, 2017

Uh oh!

dbemiller commented May 22, 2017

Uh oh!

jbAdyoulike commented May 23, 2017

Uh oh!

dbemiller May 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbemiller May 23, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller commented May 23, 2017

Uh oh!

jbAdyoulike commented May 24, 2017

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

ayl-julien commented Jul 25, 2017

Uh oh!

dbemiller commented Jul 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

jbAdyoulike commented Apr 25, 2017 •

edited

Loading

dbemiller commented May 19, 2017 •

edited

Loading

dbemiller May 23, 2017 •

edited

Loading