Skip to content

Fixed syntax error in iframe content template#1272

Merged
protonate merged 1 commit intoprebid:masterfrom
GannettDigital:pubmatic-syntax-error
Jun 7, 2017
Merged

Fixed syntax error in iframe content template#1272
protonate merged 1 commit intoprebid:masterfrom
GannettDigital:pubmatic-syntax-error

Conversation

@jmanwaring
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Syntax error encountered with script generated by the content template variable. Updated to put the ; outside of the double quotes, so it wasn't treated as a string.

Copy link
Contributor

@ptomasroos ptomasroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grevory grevory added the LGTM label Jun 7, 2017
@protonate protonate self-requested a review June 7, 2017 16:38
@protonate protonate merged commit fd7ae19 into prebid:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments