Fixing a bug with gulp watch rebuilding#1276
Merged
Conversation
…hing files with gulp serve
matthewlane
approved these changes
Jun 7, 2017
protonate
approved these changes
Jun 7, 2017
This was referenced Jun 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
I noticed that the
/dev/build was getting wiped out when runninggulp serveand making source code changes. I'm pretty sure this got introduced by addingcleanas a dependency ofwebpack(but notdevpack) when stabilitizing the CI for #1111.cleanwould execute concurrently withdevpack, rather than before it.I also found it super annoying that tests got re-run when updating the
integrationExamples. Thekarma.conffile excludesintegrationExamplesanyway, so... I'm not sure why it was being run. So I deleted it.