PubmaticRTDProvider: read and apply configurations#12935
PubmaticRTDProvider: read and apply configurations#12935pm-priyanka-deshmane wants to merge 23 commits intoprebid:masterfrom pm-priyanka-deshmane:UOE-12021
Conversation
Changes according to code review comments
Merging with Master
|
Tread carefully! This PR adds 8 linter errors and 1 linter warning (possibly disabled through directives):
|
pm-priyanka-deshmane
changed the title
|
Tread carefully! This PR adds 8 linter errors and 1 linter warning (possibly disabled through directives):
|
|
Tread carefully! This PR adds 7 linter errors and 1 linter warning (possibly disabled through directives):
|
pm-priyanka-deshmane
changed the title
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
circleci isnt running |
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
please note you had a test fail in master recently, not sure why |
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
Merging with master
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
PubMatic RTD : fixed unit test cases (#12962)
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
@Fawke Can you please review this? The required changes are done. |
|
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error and 1 linter warning (possibly disabled through directives):
|
|
Closing this PR since this had issues related to circleci. |
6 participants
Type of change
Description of change
With this change RTD provider will fetch configurations and apply the floors accordingly.