Skip to content

Fix GA Timeout for Prebid #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkendall07 merged 1 commit into from
Dec 10, 2015
Merged

Fix GA Timeout for Prebid #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/ga.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ var _disibleInteraction = { nonInteraction : true },
//GA limits the # of events to be sent see here ==> https://developers.google.com/analytics/devguides/collection/ios/v3/limits-quotas?hl=en
_eventCount = 0,
//limit data sent by leaving this false
_enableDistribution = false;
_enableDistribution = false,
_timedOutBidders = [];


/**
Expand Down Expand Up @@ -61,7 +62,7 @@ exports.enableAnalytics = function(gaOptions) {

} else if (eventObj.eventType === BID_TIMEOUT) {
var bidderArray = args[0];
sendTimedOutBiddersToGa(bidderArray);
_timedOutBidders = bidderArray;
//todo disable event listeners

} else if (eventObj.eventType === BID_WON) {
Expand All @@ -80,12 +81,12 @@ exports.enableAnalytics = function(gaOptions) {
//bidResponses
events.on(BID_RESPONSE, function(adunit, bid) {
sendBidResponseToGa(bid);

sendBidTimeouts(bid);
});

//bidTimeouts
events.on(BID_TIMEOUT, function(bidderArray) {
sendTimedOutBiddersToGa(bidderArray);
_timedOutBidders = bidderArray;
});

//wins
Expand Down Expand Up @@ -218,13 +219,18 @@ function sendBidResponseToGa(bid) {
checkAnalytics();
}

function sendTimedOutBiddersToGa(bidderArr){
utils._each(bidderArr, function(bidderCode){
_analyticsQueue.push(function() {
_eventCount++;
window[_gaGlobal]('send', 'event', _category, 'Timeouts', bidderCode, 1, _disibleInteraction);
function sendBidTimeouts(bid){

if(bid && bid.bidder){
_analyticsQueue.push(function(){
utils._each(_timedOutBidders, function(bidderCode){
if(bid.bidder === bidderCode){
_eventCount++;
window[_gaGlobal]('send', 'event', _category, 'Timeouts', bidderCode, bid.timeToRespond, _disibleInteraction);
}
});
});
});
}
checkAnalytics();
}

Expand Down