Skip to content

PulsePoint Lite adapter changes#1338

Merged
matthewlane merged 17 commits intoprebid:masterfrom
pulsepointinc:pplite
Jul 13, 2017
Merged

PulsePoint Lite adapter changes#1338
matthewlane merged 17 commits intoprebid:masterfrom
pulsepointinc:pplite

Conversation

@anand-venkatraman
Copy link
Contributor

@anand-venkatraman anand-venkatraman commented Jun 29, 2017

Type of change

  • Bugfix
  • Feature

Description of change

  1. Support for OpenRTB single request, in place of the current multi-request non-OpenRTB scheme.
  2. Support for Native (with bug-fix for Native impression tracker rendering).
  3. Fixing adapter name, with a new Alias "pulseLite". The previous name "pulsepointLite" had 14 characters and resulted in DFP key truncation (when sending all bids to DFP), due to the 20-char limit that DFP places.

Test page with the changes is here

@anand-venkatraman
ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)
2fba6a2 
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change
@anand-venkatraman
Merge remote-tracking branch 'upstream/master'
ca17acb
@anand-venkatraman
Adding bidRequest to bidFactory.createBid method as per #509
5da43c3
@anand-venkatraman
Merge branch 'master' of https://github.com/prebid/Prebid.js
cf41114
@anand-venkatraman
ET-1765: Adding support for additional params in PulsePoint adapter (#2)
62756a9
@anand-venkatraman
Merge branch 'master' of https://github.com/prebid/Prebid.js
f8fabb7
@anand-venkatraman
ET-1850: Fixing #866
b9af15c
@anand-venkatraman
Merge pull request #3 from pulsepointinc/ET-1850
6523c25 
ET-1850: Fixing #866
@anand-venkatraman
Minor fix
b5eeb7f
@anand-venkatraman
Merge branch 'master' of https://github.com/prebid/Prebid.js
0f33ef5
@anand-venkatraman
Merge branch 'master' of https://github.com/prebid/Prebid.js
b5dbd34
@anand-venkatraman
Adding multi imp ORTB support
2f95d7a
@anand-venkatraman
replacing existing lite adapter code
477921b
@anand-venkatraman
interim commit
1391827
@anand-venkatraman
pulseLite - native tests
8ef2b25
@anand-venkatraman
pulseLite - native tests
e42f73b
@anand-venkatraman
registering new adapter name via alias
05074d7
@ndhimehta ndhimehta assigned harpere and unassigned ndhimehta Jun 29, 2017
matthewlane
matthewlane approved these changes Jul 13, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the update

@matthewlane matthewlane merged commit fe00cc9 into prebid:master Jul 13, 2017
@snapwich
Copy link
Collaborator

snapwich commented Jul 14, 2017 

adaptermanager.aliasBidAdapter('pulseLite', 'pulsepointLite');

Aliasing currently requires a createNew method on the adapters, which this adapter doesn't provide right now. This needs to be fixed.

@anand-venkatraman anand-venkatraman mentioned this pull request Jul 17, 2017
Merged
8 tasks
@anand-venkatraman
Copy link
Contributor Author

anand-venkatraman commented Jul 17, 2017

@snapwich, this is addressed here - #1383

@jaiminpanchal27 jaiminpanchal27 mentioned this pull request Oct 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewlane matthewlane matthewlane approved these changes

@harpere harpere harpere approved these changes

Assignees

@harpere harpere

Labels

LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anand-venkatraman @snapwich @matthewlane @harpere @jaiminpanchal27 @ndhimehta

Comments