New imonomy Bid Adapter by ofir1122 · Pull Request #1345 · prebid/Prebid.js

ofir1122 · 2017-07-05T17:49:50Z

Adding support of imonomy prebid

test parameters for validating bids

  {
    bidder: 'imonomy',
    placementCode: 'foo',
    bidId: 'foo',
    sizes: [[300, 250]],
    params: {
      publisher_id: '14567721164',
    }
  }

contact email of the adapter’s maintainer
tech@imonomy.com
amit@imonmy.com
[X ] official adapter submission

Type of change

Description of change

test parameters for validating bids

{
  bidder: 'imonomy',
  params: {
           publisher_id: '14567721164'
  }
}

contact email of the adapter’s maintainer
tech@imonomy.com
amit@imonmy.com
official adapter submission

Other information

Adding support of imonomy prebid test parameters for validating bids { bidder: 'imonomy', params: { publisher_id: '14567721164' } } contact email of the adapter’s maintainer tech@imonomy.com amit@imonmy.com [X ] official adapter submission

dbemiller · 2017-07-13T15:30:17Z

Per the project standards, this needs unit tests.

fix warning

+Fix File references

ofir1122 · 2017-07-15T22:10:44Z

@dbemiller Thank you for your comment. I added the unit tests.

dbemiller

I get no bids back with your test params.

One bug is that you're not registering your bid adapter. Check out some of the other adapter files for example:

adaptermanager.registerBidAdapter(new HiroMediaAdapter, 'hiromedia');

There may be others after that... but that's at least one.

dbemiller · 2017-07-20T20:59:52Z

test/spec/modules/imonomyBidAdapter_spec.js

@@ -0,0 +1,111 @@
+/* jshint -W030 */


What's up with this? We don't use jshint...

dbemiller · 2017-07-26T13:45:52Z

modules/imonomyBidAdapter.js

+
+  function _callBids(params) {
+    var request        = [];
+    var siteRef        = "";


A recently merged PR fixed a bug which was preventing adapters from being linted.

This line (along with many other things in this file) will fail the linting rules... so you'll have to pull the master branch again and fix the errors before we can merge it.

dbemiller · 2017-07-26T13:53:54Z

modules/imonomyBidAdapter.js

+        request.push(formRequestUrl(bid.params));
+      }
+
+      $$PREBID_GLOBAL$$[callbackName] = handleCallback(bids);


Just so you know: JSONP isn't going to be allowed in Prebid 1.0 (most likely coming in Q4 of this year). It's fine if you want to build your adapter this way now, but just be aware that you'll probably have to refactor to stay in the project long-term.

dbemiller · 2017-07-26T14:23:28Z

modules/imonomyBidAdapter.js

+    return null;
+  }
+
+  function encode64(input) {


Are you just re-implementing atob here? Or am I missing something?

+ fixed all lint isses on adapter + replace encode64 with btoa + add some more unit tests

ofir1122 · 2017-07-26T17:36:12Z

@dbemiller Thank you for the feedback.
I fix all comments and updated the test parameters to make sure you will get a bid.
About JSONP we will rewrite the adapter before Q4 (thanks for the notice)

dbemiller · 2017-07-27T13:51:32Z

I'm seeing a bid now, but no ad in the page.

The integrationExamples/gpt/hello_world.hmtl page exists to help test bid adapters end-to-end. Replace the AppNexus bid with your test params, run gulp serve, and then use that page to help debug.

ofir1122 · 2017-07-27T16:49:59Z

@dbemiller hi seems that the bid response was under 10 cent. I configured it and now it works.

jaiminpanchal27

LGTM

jaiminpanchal27 · 2017-08-02T16:21:00Z

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

* New imonomy Bid Adapter Adding support of imonomy prebid test parameters for validating bids { bidder: 'imonomy', params: { publisher_id: '14567721164' } } contact email of the adapter’s maintainer tech@imonomy.com amit@imonmy.com [X ] official adapter submission * identetion fixes fix warning * add imonomyBidAdapter unit testing * Fix File Location +Fix File references * indentaion on unit test * more identation fixes * no-trailing-spaces * remove jshint + fixed all lint isses on adapter + replace encode64 with btoa + add some more unit tests * fix - A space is required after ',' comma-spacing

New imonomy Bid Adapter

9b04deb

Adding support of imonomy prebid test parameters for validating bids { bidder: 'imonomy', params: { publisher_id: '14567721164' } } contact email of the adapter’s maintainer tech@imonomy.com amit@imonmy.com [X ] official adapter submission

matthewlane added the needs review label Jul 12, 2017

dbemiller added needs update and removed needs review labels Jul 13, 2017

ofir1122 and others added 6 commits July 15, 2017 23:24

identetion fixes

bc211bf

fix warning

add imonomyBidAdapter unit testing

5785be8

Fix File Location

e32bc1d

+Fix File references

indentaion on unit test

e01a8c9

more identation fixes

99fac08

no-trailing-spaces

5325f43

dbemiller added needs review and removed needs update labels Jul 17, 2017

matthewlane requested a review from dbemiller July 18, 2017 21:42

matthewlane assigned dbemiller Jul 18, 2017

dbemiller suggested changes Jul 26, 2017

View reviewed changes

dbemiller added needs update and removed needs review labels Jul 26, 2017

Denis Rogov added 2 commits July 26, 2017 20:14

remove jshint

ed1898d

+ fixed all lint isses on adapter + replace encode64 with btoa + add some more unit tests

fix - A space is required after ',' comma-spacing

0f77e24

dbemiller approved these changes Jul 27, 2017

View reviewed changes

dbemiller added LGTM and removed needs update labels Jul 27, 2017

dbemiller requested a review from jaiminpanchal27 August 1, 2017 14:12

dbemiller assigned jaiminpanchal27 Aug 2, 2017

jaiminpanchal27 approved these changes Aug 2, 2017

View reviewed changes

jaiminpanchal27 merged commit a261fb3 into prebid:master Aug 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New imonomy Bid Adapter#1345

New imonomy Bid Adapter#1345
jaiminpanchal27 merged 9 commits intoprebid:masterfrom
ofir1122:patch-1

ofir1122 commented Jul 5, 2017 •

edited

Loading

Uh oh!

dbemiller commented Jul 13, 2017

Uh oh!

ofir1122 commented Jul 15, 2017

Uh oh!

dbemiller left a comment

Uh oh!

dbemiller Jul 20, 2017

Uh oh!

dbemiller Jul 26, 2017

Uh oh!

dbemiller Jul 26, 2017

Uh oh!

dbemiller Jul 26, 2017

Uh oh!

ofir1122 commented Jul 26, 2017 •

edited

Loading

Uh oh!

dbemiller commented Jul 27, 2017

Uh oh!

ofir1122 commented Jul 27, 2017

Uh oh!

jaiminpanchal27 left a comment

Uh oh!

jaiminpanchal27 commented Aug 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

ofir1122 commented Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

dbemiller commented Jul 13, 2017

Uh oh!

ofir1122 commented Jul 15, 2017

Uh oh!

dbemiller left a comment

Choose a reason for hiding this comment

Uh oh!

dbemiller Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller Jul 26, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller Jul 26, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller Jul 26, 2017

Choose a reason for hiding this comment

Uh oh!

ofir1122 commented Jul 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbemiller commented Jul 27, 2017

Uh oh!

ofir1122 commented Jul 27, 2017

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 commented Aug 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

ofir1122 commented Jul 5, 2017 •

edited

Loading

ofir1122 commented Jul 26, 2017 •

edited

Loading