IIQ: Allow Publisher to Pass Group #14256
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces support for allowing publishers to override the "group" parameter in both the IntentIQ Analytics Adapter and IntentIQ ID System modules. When a "group" value is provided in the configuration, it takes precedence over values stored in local storage or returned by the server, ensuring consistent group assignment across analytics payloads and GAM targeting.
Key changes:
- Added manual group override functionality that prevents server responses from changing the configured group value
- Implemented config fallback logic to support group configuration via both
userSync.userIdsandenableAnalyticsoptions - Added comprehensive test coverage for group override behavior and config fallback scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/intentIqIdSystem.js | Implements group override logic to preserve manually configured group values and prevent server responses from overwriting them |
| modules/intentIqAnalyticsAdapter.js | Adds group parameter support in analytics initialization and implements config fallback mechanism |
| test/spec/modules/intentIqIdSystem_spec.js | Adds comprehensive tests for group override functionality including server response handling and GAM targeting |
| test/spec/modules/intentIqAnalyticsAdapter_spec.js | Adds tests for group override, payload inclusion, and config fallback behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@DimaIntentIQ could you review? |
Hi @ncolletti, |
| localStorage.setItem(FIRST_PARTY_KEY, '{"pcid":"testpcid", "group": "B"}'); | ||
| localStorage.setItem(FIRST_PARTY_KEY + '_' + partner, '{"data":"testdata"}'); | ||
|
|
||
| events.emit(EVENTS.BID_WON, wonRequest); |
There was a problem hiding this comment.
these tests are failing with wonRequest is undefined
3 participants
This pull request introduces support for overriding the "group" parameter in both the IntentIQ Analytics Adapter and IntentIQ ID System modules. The changes ensure that if a "group" value is provided in the configuration, it takes precedence over values stored in local storage or returned by the server, and is properly reflected in analytics payloads and GAM targeting.