Pollux Adapter by polluxnetwork · Pull Request #1431 · prebid/Prebid.js

polluxnetwork · 2017-07-28T09:26:19Z

Type of change

Description of change

Adding an adapter for Pollux Network, LLC.
Added module, test spec and integration example for Pollux Network Bid Adapter.

test parameters for validating bids

{
	bidder: 'pollux',
	params: {
	   zone: '1806'
	}
},
{
	bidder: 'pollux',
	params: {
	   zone: '276'
	}
}

Be sure to test the integration with your adserver using the Hello World sample page.
There is also a pollux test page with the parameters already set.

contact email of the adapter’s maintainer tech[at]polluxnetwork[dot]com
official adapter submission

Added module, test spec and integration example for Pollux Network Bid Adapter

Update Pollux default domain on prebid adapter

On Utils.js make getParameterByName method public

DaLt0n

its ok

jaiminpanchal27

@polluxnetwork Was able to verify bids back and ad render.
I have left some comments. Please check

jaiminpanchal27 · 2017-08-01T19:22:45Z

integrationExamples/pollux/zone_728x90.html

@@ -0,0 +1,105 @@
+<!DOCTYPE html>


Move this example page to integrationExamples/gpt/pollux_zone_728x90.html

jaiminpanchal27 · 2017-08-01T19:33:48Z

modules/polluxBidAdapter.js

+      placementCode = bidObj.placementCode;
+    }
+    if (bidObj && response.cpm > 0 && !!response.ad) {
+      bidObject = bidfactory.createBid(STATUS.GOOD);


pass bidRequest as second parameter. This will match request response pairs

jaiminpanchal27 · 2017-08-01T19:35:12Z

modules/polluxBidAdapter.js

+      bidObject.width = response.width;
+      bidObject.height = response.height;
+    } else {
+      bidObject = bidfactory.createBid(STATUS.NO_BID);


pass bidRequest as second parameter. This will match request response pairs

jaiminpanchal27 · 2017-08-01T19:37:58Z

test/spec/modules/polluxBidAdapter_spec.js

+  sinon.stub(bidManager, 'addBidResponse');
+  const adLoaderStub = sinon.stub(adLoader, 'loadScript');
+
+  describe('callBids', () => {


Please add more test cases. Your test coverage seems just 54.1 %. Make it atleast >85
To view test coverage run 1) gulp test-coverage 2) gulp view-coverage

Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - prebid#1431 (review)

hdjvieira · 2017-08-04T12:40:38Z

@jaiminpanchal27 Just pushed the changes you requested. Please review them at your best convenience, and thanks a lot for your help.

jaiminpanchal27

Changes in module are good. I have left some comments for unit tests. Please check.
Thanks.

jaiminpanchal27 · 2017-08-08T16:24:48Z

test/spec/modules/polluxBidAdapter_spec.js

+      adUnits.push(unit);
+
+      if (typeof ($$PREBID_GLOBAL$$._bidsRequested) === 'undefined') {
+        $$PREBID_GLOBAL$$._bidsRequested = [params];


Avoid using $$PREBID_GLOBAL$$ public vars in unit tests. Reason being it can affect other test cases since every one shares the same variables. Also from 1.0 adapters will not be access these variables so its good to refactor it now.

For reference you can check these unit tests:
https://github.com/prebid/Prebid.js/blob/master/test/spec/modules/pulsepointBidAdapter_spec.js

jaiminpanchal27 · 2017-08-08T16:29:01Z

test/spec/modules/polluxBidAdapter_spec.js

+    });
+
+    it('should return complete bid response ad (html)', function() {
+      var stubAddBidResponse = sinon.stub(bidmanager, 'addBidResponse');


stub creation and its restore should always be in beforeEach and afterEach hooks. Reason being if some test fails and the next test case is trying to stub the same method than you will get following error from sinon
TypeError: Attempted to wrap method which is already wrapped

- Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter.

jaiminpanchal27

LGTM

This line was added in prebid#1409, removing this then I'll merge

@jaiminpanchal27

* Added PolluxNetwork Bid Adapter Added module, test spec and integration example for Pollux Network Bid Adapter * Update Pollux domain Update Pollux default domain on prebid adapter * Export getParameterByName method On Utils.js make getParameterByName method public * Executed changes requested by @jaiminpanchal27 on 2017-08-01 Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - prebid#1431 (review) * Fixed Eslint errors on commit f745fe1 * Executed changes requested on PR#1431 review #54993573 - Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter. * Remove redundant export This line was added in prebid#1409, removing this then I'll merge

@jaiminpanchal27

* Added PolluxNetwork Bid Adapter Added module, test spec and integration example for Pollux Network Bid Adapter * Update Pollux domain Update Pollux default domain on prebid adapter * Export getParameterByName method On Utils.js make getParameterByName method public * Executed changes requested by @jaiminpanchal27 on 2017-08-01 Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - #1431 (review) * Fixed Eslint errors on commit f745fe1 * Executed changes requested on PR#1431 review #54993573 - Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter. * Remove redundant export This line was added in #1409, removing this then I'll merge * Update Pollux Adapter to v1.0 * Changes requested on Pollux Adapter pull request #1694 review #74933409 * Changes requested on Pollux Adapter pull request #1694 review #75505070 Rmoved parameter bidderCode from bid responses * Fixed breaking changes to serverResponse in interpretResponse method Parameter serverResponse of method interpretResponse in bid adapter changed from array of bids to an object, where bids are now nested within its parameter body. Plus a refactor of var declaration and log messages. * Fix lint errors on push for commit cc653a

hdjvieira added 3 commits July 27, 2017 17:34

Added PolluxNetwork Bid Adapter

a7c0709

Added module, test spec and integration example for Pollux Network Bid Adapter

Update Pollux domain

a6000c5

Update Pollux default domain on prebid adapter

Export getParameterByName method

52e1dc8

On Utils.js make getParameterByName method public

DaLt0n approved these changes Jul 28, 2017

View reviewed changes

hdjvieira approved these changes Jul 28, 2017

View reviewed changes

rmloveland mentioned this pull request Jul 31, 2017

Bidder's Params For Pollux Adapter prebid/prebid.github.io#311

Merged

dbemiller assigned jaiminpanchal27 Jul 31, 2017

jaiminpanchal27 requested changes Aug 1, 2017

View reviewed changes

jaiminpanchal27 added the needs update label Aug 1, 2017

hdjvieira added 2 commits August 4, 2017 16:34

Merge remote-tracking branch 'upstream/master'

5f6cbeb

Fixed Eslint errors on commit f745fe1

33c5ede

jaiminpanchal27 requested changes Aug 8, 2017

View reviewed changes

hdjvieira added 3 commits August 9, 2017 10:38

Merge remote-tracking branch 'upstream/master'

e41b0a6

Executed changes requested on PR#1431 review #54993573

34131a6

- Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter.

Merge remote-tracking branch 'upstream/master'

2967409

jaiminpanchal27 approved these changes Aug 14, 2017

View reviewed changes

jaiminpanchal27 previously approved these changes Aug 14, 2017

View reviewed changes

jaiminpanchal27 requested a review from matthewlane August 14, 2017 14:34

jaiminpanchal27 assigned matthewlane Aug 14, 2017

jaiminpanchal27 added LGTM and removed needs update labels Aug 14, 2017

Remove redundant export

1d3ef09

This line was added in prebid#1409, removing this then I'll merge

matthewlane dismissed jaiminpanchal27’s stale review via 1d3ef09 August 15, 2017 16:53

matthewlane approved these changes Aug 15, 2017

View reviewed changes

matthewlane merged commit 302560f into prebid:master Aug 15, 2017

hdjvieira mentioned this pull request Oct 16, 2017

Update Pollux Adapter to v1.0 #1694

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pollux Adapter#1431

Pollux Adapter#1431
matthewlane merged 10 commits intoprebid:masterfrom
polluxnetwork:master

polluxnetwork commented Jul 28, 2017

Uh oh!

DaLt0n left a comment

Uh oh!

jaiminpanchal27 left a comment

Uh oh!

jaiminpanchal27 Aug 1, 2017

Uh oh!

jaiminpanchal27 Aug 1, 2017

Uh oh!

jaiminpanchal27 Aug 1, 2017

Uh oh!

jaiminpanchal27 Aug 1, 2017

Uh oh!

hdjvieira commented Aug 4, 2017

Uh oh!

jaiminpanchal27 left a comment

Uh oh!

jaiminpanchal27 Aug 8, 2017

Uh oh!

jaiminpanchal27 Aug 8, 2017

Uh oh!

jaiminpanchal27 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

polluxnetwork commented Jul 28, 2017

Type of change

Description of change

Uh oh!

DaLt0n left a comment

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 1, 2017

Choose a reason for hiding this comment

Uh oh!

hdjvieira commented Aug 4, 2017

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments