IntentIq ID Module & Analytical Adapter: increase default server call time, support region, bugfixes#14374
Conversation
* AGT-765: pos and size * AGT-765: Tests for position resolving * AGT-765: Test fix
* AGT-756: vrref in payload fix * remove comment * AGT-756: Fix vrref bug * AGT-756: Remove comments * AGT-756: Test for vrref
* fix typo, remove parameter duplication * update doc examples
DimaIntentIQ
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dec84b084c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export const getIiqServerAddress = (configParams = {}) => { | ||
| if (typeof configParams?.iiqServerAddress === 'string') return configParams.iiqServerAddress; | ||
| return buildServerAddress('api', configParams.region); |
There was a problem hiding this comment.
This helper now builds API/reporting/sync base URLs solely from configParams.region, which means GDPR detection from CMP no longer influences endpoint choice. If a publisher previously relied on automatic GDPR routing (e.g., gdprString present but no explicit region configured), requests will now go to *.intentiq.com instead of *-gdpr.intentiq.com, changing behavior for existing integrations and potentially violating data-residency/consent expectations. Consider retaining the CMP-based GDPR fallback (or mapping gdprString → region) so default behavior doesn’t regress for EU traffic.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
In our system, each partner account is provisioned for a specific region, and traffic should use the matching regional account. So region routing is intentional and explicit — the account must match the target region.
| const firstKey = Object.keys(mediaTypes)[0]; | ||
| const pos = mediaTypes[firstKey]?.pos; |
There was a problem hiding this comment.
This picks the first key in adUnit.mediaTypes to read pos. For multi-format adUnits (e.g., banner + video), object key order is not guaranteed to match the winning mediaType, so a video win can be reported with the banner pos (or undefined), corrupting analytics. Consider selecting mediaTypes[data.mediaType]?.pos (or mapping from adType) when the event includes a media type.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
pos is defined at the adUnit level and is identical across mediaTypes, so reading it from any mediaTypes entry yields the same value. We don’t depend on key order for correctness in this case.
Pull Request Test Coverage Report for Build 21288978463Details
💛 - Coveralls |
4 participants
Type of change
Other information
Related pull requests in prebid.io -> prebid/prebid.github.io#6408