Conversation
|
Thanks for the PR @JohnBuonomo Can you please submit your params object needed to wire up the adapter? Example Also please include actual test params that can be used to retrieve an ad for validation. Thanks very much! |
|
@mkendall07 The testing params are included in that last commit. Let me know if something else is needed. -John |
JohnBuonomo
force-pushed
the
master
branch
2 times, most recently
from
8dab9be to
32c0966
Compare
|
Hi @JohnBuonomo, the placement size info is already set on the adUnit object here, so you can remove the height and width properties from the springserve bid object. |
|
@protonate I made the requested changes to the params. |
|
Thanks for the changes, @JohnBuonomo. The height and width are undefined when set in |
src/adapters/springserve.js
Outdated
|
Thanks for the fixes. Please squash commits and we can get this merged. Thanks! |
springserve adapter test params springserve adapter - test setup; small fix springserve adapter get's sizes from ad unit update test params recover sizes from bidrequest springserve adapter indentation
|
Squashed. Thank you! |
| //assign properties from the original request to the bid object | ||
| for (var i = 0; i < requestObj.bids.length; i++ ){ | ||
| var bidRequest = requestObj.bids[i]; | ||
| if(bidRequest.bidder = "springserve"){ |
There was a problem hiding this comment.
@JohnBuonomo I noticed this while applying code style tools, but I expect you want this to be an equality check and not assignment. I'll put this fix into the upcoming code style PR.
There was a problem hiding this comment.
@protonate Ugh. Yes. Thank you for catching that.
Release/2.16.0
3 participants
adapter for the springserve bidder