Skip to content

PubMatic adapter updated#1699

Closed
PubMatic-OpenWrap wants to merge 13 commits intoprebid:masterfrom
PubMatic-OpenWrap:PubMatic_adapter
Closed

PubMatic adapter updated#1699
PubMatic-OpenWrap wants to merge 13 commits intoprebid:masterfrom
PubMatic-OpenWrap:PubMatic_adapter

Conversation

@PubMatic-OpenWrap
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • [x ] New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [x ] Build related changes
  • [ x] CI related changes
  • [ x] Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

Other information

@mkendall07
Copy link
Contributor

@PubMatic-OpenWrap
it seems like you changed file permissions on all the files. Please revert those changes so we can review. Thanks.

@PubMatic-OpenWrap
Copy link
Contributor Author

Hi @mkendall07 ,
I am not sure what exact steps I need to take to revert file permissions.
Can you help me ?
Thanks.

@dbemiller
Copy link
Contributor

dbemiller commented Oct 17, 2017

On linux/mac, chmod: https://linux.die.net/man/1/chmod

Not sure about Windows

@PubMatic-OpenWrap
Copy link
Contributor Author

Thanks @dbemiller for your quick response.
But I am using Windows 7 Pro, and not sure what permissions should be for all files.

@dbemiller
Copy link
Contributor

Honestly... if it were me, I'd start fresh from master, copy/paste all the changes I intended to make, and be careful not to change the file permissions this time. If I didn't do it intentionally, I'd avoid using whatever IDE I used the first time, because it might have set them automatically.

Otherwise, you can view the correct file permissions by checking out master, viewing them, and then checking out your current branch and changing them again. It looks like you changed ~100 files, though... so this might take a while.

Googling for "windows 7 pro file permissions" sent me here: https://technet.microsoft.com/en-us/library/cc754344(v=ws.11).aspx

Maybe that will help?

@mkendall07
Copy link
Contributor

@PubMatic-OpenWrap
I agree with Dave suggestion, starting from scratch and committing just your file is the best option here.

@dbemiller
Copy link
Contributor

Closing this, in light of #1707

@dbemiller dbemiller closed this Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments