Sovrn adapter - add no bid responses for all placements that are not mentioned in the Sovrn bid response#183
Merged
pdramos1 merged 1 commit intoprebid:masterfrom Feb 9, 2016
baragona:sovrn_fix
Merged
Sovrn adapter - add no bid responses for all placements that are not mentioned in the Sovrn bid response#183pdramos1 merged 1 commit intoprebid:masterfrom baragona:sovrn_fix
pdramos1 merged 1 commit intoprebid:masterfrom
baragona:sovrn_fix
Conversation
…entioned in the Sovrn bid response
Collaborator
|
Thanks for moving this to a separate PR. |
pdramos1
added a commit
that referenced
this pull request
Feb 9, 2016
Sovrn adapter - add no bid responses for all placements that are not mentioned in the Sovrn bid response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed version of #163
My understanding is that the bid manager wants to see addBidResponse called the same number of times as expectedBidsCount, before executing the callback. Sovrn adapter doesn't set expectedBidsCount, so it will be set to the default (from adaptermanager.js):
Multiple Sovrn bid requests are merged into a single call to sovrn. When sovrn encounters an error or doesn't bid on anything, they don't sent an explicit no-bid response for each bid request. Before this PR change, the sovrn adapter called addBidResponse only 1 time in this case.
Thus addBidResponse may only be called 1 time. But bidmanager expects it to be called more times, so it does not fire the callback immediately, instead, it waits for the timeout to occur.
I've been running this code in production for a several weeks now and it seems to work well.