Vidazoo bid adapter by thewizarodofoz · Pull Request #1916 · prebid/Prebid.js

thewizarodofoz · 2017-12-05T14:50:41Z

Description of change

test parameters for validating bids

{
  bidder: 'vidazoo',
    params: {
    cId: '5a1c419d95fce900044c334e',
    pId: '59ac17c192832d0011283fe3',
    bidFloor: 0.0001
  }
}

contact email of the adapter’s maintainer: devs@vidazoo.com
*official adapter submission

Other information

matthewlane · 2017-12-05T17:59:18Z

test/spec/modules/vidazooBidAdapter_spec.js

+    });
+
+    it('should take default TTL', () => {
+      const serverResponse = utils.cloneJson(SERVER_RESPONSE);


In #1910 utils.cloneJson was renamed to utils.deepClone, updating this line should get the test passing again

matthewlane · 2017-12-05T23:23:41Z

modules/vidazooBidAdapter.js

+  try {
+    return [{
+      requestId: bidId,
+      bidderCode: BIDDER_CODE,


bidderCode will be set automatically by bidderFactory now, this line can be dropped

@matthewlane How will bidderFactory know our bidderCode?

you call:

registerBidder({ code: BIDDER_CODE, ... })

It keeps track internally.

deepClone instead of cloneJson

thewizarodofoz · 2017-12-14T09:10:51Z

@matthewlane @dbemiller Thanks for all you help - tests are now passing. Anything else you need from me?

matthewlane · 2017-12-19T21:32:52Z

@thewizarodofoz Changes look good. Currently getting back a 204 No Content response from this adapter's endpoint though, we check this to validate bid responses, please advise

thewizarodofoz · 2017-12-20T12:44:47Z

@matthewlane Please use these params:

bids: [{
  bidder: 'vidazoo',
  params: {
    cId: '5a3a543645ea6b0004869360',
    pId: '59ac17c192832d0011283fe3',
    bidFloor: 0.0001
  }
}]

They will return a valid response.

thewizarodofoz · 2018-01-08T08:49:49Z

@jaiminpanchal27 Do you need anything from us? Anything we can do to finish this up?

mkendall07 · 2018-01-08T22:11:31Z

@thewizarodofoz
Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page.

thewizarodofoz · 2018-01-09T11:33:09Z

@mkendall07 done: prebid/prebid.github.io#538.

thewizarodofoz · 2018-01-15T09:43:17Z

@mkendall07 any updates on this?

thewizarodofoz · 2018-01-16T19:54:03Z

Hey @mkendall07, just wanted to let you know that @rmloveland commented on our docs pull request:

Hey @thewizarodofoz , we will be able to merge this once your bid adapter goes out in a Prebid.js release. This is necessary because we generate the download page on Prebid.org from the adapter docs.

So it's your move now :-)

mkendall07 · 2018-01-16T19:56:09Z

modules/vidazooBidAdapter.js

+const CURRENCY = 'USD';
+const TTL_SECONDS = 60 * 5;
+export const URL = '//prebid.cliipa.com';
+// export const URL = '//localhost:8067';


dead code should be removed.

mkendall07 · 2018-01-16T20:01:01Z

modules/vidazooBidAdapter.js

+    method: 'GET',
+    url: `${URL}/prebid/${cId}`,
+    data: {
+      width: size[0],


this may break for double size arrays (ie [[300,250]] ). See https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L113 for help parsing. You can use this function.

mkendall07 · 2018-01-16T20:04:06Z

modules/vidazooBidAdapter.js

+      }
+    });
+  });
+  return Object.values(syncs);


Object.values isn't supported yet. Please re-write.

mkendall07 · 2018-01-17T02:56:53Z

@thewizarodofoz
Left a few comments

removed dead code (debug url), handled sizes more safely, removed usage of Object.values

updates tests to fit changes in adapter

thewizarodofoz · 2018-01-21T15:48:42Z

@mkendall07 Thanks! Waiting for your re-review.

jaiminpanchal27 · 2018-01-23T15:27:59Z

test/spec/modules/vidazooBidAdapter_spec.js

+
+    it('should build request for each size', () => {
+      const requests = adapter.buildRequests([BID]);
+      console.log(JSON.stringify(requests));


@thewizarodofoz remove console.log

thewizarodofoz · 2018-01-25T16:04:53Z

@mkendall07 @jaiminpanchal27 good to go?

mkendall07

LGTM

thewizarodofoz · 2018-01-26T06:44:12Z

Thanks for the support and coopororation everyone!

thewizarodofoz added 3 commits December 5, 2017 16:39

Adding Vidazoo bid adapter

433bb6d

Adding Vidazoo bid adapter tests

1e1e05a

production url

f0bd5e9

matthewlane self-requested a review December 5, 2017 17:56

matthewlane self-assigned this Dec 5, 2017

matthewlane added the needs review label Dec 5, 2017

matthewlane reviewed Dec 5, 2017

View reviewed changes

matthewlane added the needs update label Dec 5, 2017

thewizarodofoz added 3 commits December 11, 2017 12:38

Update vidazooBidAdapter_spec.js

e1a217b

deepClone instead of cloneJson

Update vidazooBidAdapter.js

3a18432

Update vidazooBidAdapter_spec.js

f013319

matthewlane added not receiving bids and removed needs update labels Dec 19, 2017

matthewlane approved these changes Dec 20, 2017

View reviewed changes

matthewlane added LGTM and removed needs review not receiving bids labels Dec 20, 2017

matthewlane requested a review from jaiminpanchal27 December 21, 2017 20:10

matthewlane assigned jaiminpanchal27 and unassigned matthewlane Jan 3, 2018

mkendall07 added the needs docs label Jan 8, 2018

mkendall07 suggested changes Jan 16, 2018

View reviewed changes

mkendall07 assigned mkendall07 and unassigned jaiminpanchal27 Jan 17, 2018

mkendall07 removed the request for review from jaiminpanchal27 January 17, 2018 02:56

thewizarodofoz added 4 commits January 17, 2018 10:57

Update vidazooBidAdapter.js

152a50b

removed dead code (debug url), handled sizes more safely, removed usage of Object.values

Update vidazooBidAdapter_spec.js

3888c87

updates tests to fit changes in adapter

Update vidazooBidAdapter.js

969469b

Update vidazooBidAdapter.js

0b8c5ff

jaiminpanchal27 requested changes Jan 23, 2018

View reviewed changes

mkendall07 added needs update and removed needs docs labels Jan 23, 2018

Update vidazooBidAdapter_spec.js

beab27b

mkendall07 added this to the Prebid 1.3 release milestone Jan 24, 2018

mkendall07 approved these changes Jan 25, 2018

View reviewed changes

mkendall07 merged commit 70781c9 into prebid:master Jan 25, 2018

thewizarodofoz mentioned this pull request Jan 26, 2018

Create vidazoo.md prebid/prebid.github.io#538

Merged

bretg removed the needs update label Jan 29, 2018

Conversation

thewizarodofoz commented Dec 5, 2017

Description of change

test parameters for validating bids

Other information

Uh oh!

matthewlane Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewlane Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

thewizarodofoz Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

dbemiller Dec 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thewizarodofoz commented Dec 14, 2017

Uh oh!

matthewlane commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thewizarodofoz commented Dec 20, 2017

Uh oh!

thewizarodofoz commented Jan 8, 2018

Uh oh!

mkendall07 commented Jan 8, 2018

Uh oh!

thewizarodofoz commented Jan 9, 2018

Uh oh!

thewizarodofoz commented Jan 15, 2018

Uh oh!

thewizarodofoz commented Jan 16, 2018

Uh oh!

mkendall07 Jan 16, 2018

Choose a reason for hiding this comment

Uh oh!

mkendall07 Jan 16, 2018

Choose a reason for hiding this comment

Uh oh!

mkendall07 Jan 16, 2018

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Jan 17, 2018

Uh oh!

thewizarodofoz commented Jan 21, 2018

Uh oh!

jaiminpanchal27 Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

thewizarodofoz commented Jan 25, 2018

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

thewizarodofoz commented Jan 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

matthewlane Dec 5, 2017 •

edited

Loading

dbemiller Dec 11, 2017 •

edited

Loading

matthewlane commented Dec 19, 2017 •

edited

Loading