Conversation
|
unit tests should be added for the change. |
| } | ||
|
|
||
| if (userSync.iframeEnabled) { | ||
| userSync.registerSync('iframe', 'admedia', '//b.admedia.com/sync/iframe/'); |
There was a problem hiding this comment.
userSync.iframeEnabled does not exist. You'd have to look at the config directly, like config.getConfig('userSync');
There was a problem hiding this comment.
Updated to use config.
|
Using config object and added unit tests. |
|
@devmusings looks like there's a conflict in |
| }); | ||
|
|
||
| it('should call usersync after default 3000 seconds', () => { | ||
| window.setTimeout(function() { |
There was a problem hiding this comment.
A couple of problems with the setTimeout here.
- you're not using an async callback (usually called
done) to notify the framework the test is finished. - if this works, its adding a 3 second delay every time the tests are run.
I think a better approach would be to test that your usersync.registerSync() calls are happening as expected and let the usersync module tests validate that they are triggered properly.
There was a problem hiding this comment.
Agreed. Updated the tests.
|
@devmusings |
4 participants
Type of change
Description of change
Added usersync to Admedia's bidder.
Other information
Suggested updates per #1864