Smartyads Adapter 1.x#2080
Conversation
|
Thanks for the submission @isss1650. While the review is taking place, please note that we will require that a file for this adapter be added to https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders |
modules/smartyadsBidAdapter.js
Outdated
| } | ||
| switch (bid['mediaType']) { | ||
| case 'banner': | ||
| return Boolean(bid['width'] && bid['height'] && bid['ad']); |
There was a problem hiding this comment.
don't need the Boolean function here. Also prefer dot notation bid.width vs bracket notation for known keys.
There was a problem hiding this comment.
Dot notation added.
Boolean - disagree. In my opinion, the function must always return data of the same type.
The validation function must return a value in the boolean data type.
Don't you agree with me?
There was a problem hiding this comment.
yeah that's fine I'm just use to reviewing code with !! instead of Boolean but it should be functionally equivalent.
modules/smartyadsBidAdapter.js
Outdated
| return false; | ||
| } | ||
| switch (bid['mediaType']) { | ||
| case 'banner': |
There was a problem hiding this comment.
we have constants for these types you can use.
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
LGTM. One comment, your user sync URL http://ssp-nj.webtradehub.com/?c=o&m=cookie returns a 404
* master: (27 commits) Increment pre version Prebid 1.5.0 Release Fix cross-platform test failures (prebid#2228) Fix uncahced video bids from multi-response array triggering callback early (prebid#2219) Add vuble adapter (prebid#2201) Update Vidazoo domain (prebid#2223) InSkin Bid Adapter: remove referrer field from request body (prebid#2217) Gamma Support UserSync Endpoint (prebid#2216) Feature/stale bot (prebid#2192) 33Across Bid Adapter: updated user sync endpoint (prebid#2193) Adding PR_REVIEW guideline (prebid#2159) Add FairTrade Bid Adapter (prebid#2147) Add banner support to Beachfront adapter (prebid#2117) Smartyads Adapter 1.x (prebid#2080) Audience Network: allow native bids for non-IAB sizes (prebid#2203) Update position default value in rubicon (prebid#2214) Auctionmanager spec refactor pr (prebid#2155) fix mediaType being overwritten by undefined in rubicon bid adapter (prebid#2209) Fix lint error (prebid#2208) VAST support in adform adapter (prebid#2173) ...
6 participants
Type of change
Description of change
Added HB adapter for SmartyAds SSP
contact email of the adapter’s maintainer: vladis@smartyads.com
official adapter submission