Skip to content

RockYou Adapter: Update for multiple ad unit support#2198

Merged
matthewlane merged 6 commits intoprebid:masterfrom
RockYou-Ads:master
Feb 28, 2018
Merged

RockYou Adapter: Update for multiple ad unit support#2198
matthewlane merged 6 commits intoprebid:masterfrom
RockYou-Ads:master

Conversation

@cameronhotchkies
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updated the RockYou Adapter to support:

  • sizes coming from the mediaTypes object.
  • an updated inventory zone
  • multiple AdUnits
  • Test parameters have been updated (including in the README)
{
    code: 'banner-div',
    mediaTypes: {
      banner: {
        sizes: [[720, 480]]
      }
    },

    bids: [{
          bidder: 'rockyou',
          params: {
            placementId: '4954'
          }
        }]
  },

  // Video (outstream)
  {
    code: 'video-outstream',
    mediaTypes: {
      video: {
        context: 'outstream',
        playerSize: [720, 480]
      }
    },
    bids: [{
      bidder: 'rockyou',
      params: {
        placementId: '4957'
      }
    }]
  }

Note: no prebid doc changes are required for this PR

Cameron Hotchkies and others added 6 commits December 19, 2017 10:33
RockYou Adapter:  
* Updated to support size coming from the mediaTypes object, multiple AdUnit support
* RockYou Adapter: Readme updates
* RockYou Adapter: explicitly pass request.bidId in the response object
* RockYou Adapter: Updated sync URL
@matthewlane matthewlane merged commit f169a85 into prebid:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments