PulsePoint Adapter GDPR support#2471
PulsePoint Adapter GDPR support#2471jsnellbaker merged 26 commits intoprebid:masterfrom pulsepointinc:pulsepoint-gdpr
Conversation
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
Hi @anand-venkatraman, Thanks for submitting this update. There is a change needed, please see the details in-line below.
Also, can you please submit a PR to the docs repo to add a gdpr_supported: true variable to your respective page in the bidders directory? This will flag your adapter as GDPR compliant in the prebid docs. Thanks
modules/pulsepointBidAdapter.js
Outdated
| app: app(bidRequests), | ||
| device: device(), | ||
| }; | ||
| applyGdpr(bidRequests, request); |
There was a problem hiding this comment.
The GDPR consent data does not exist in the bidRequests object, but rather in the bidderRequest object (which is the second argument).
In this case, you'll need to modify the buildRequests function call like so:
buildRequests: (bidRequests, bidderRequest) => {
Then you can pass in the bidderRequest value into the applyGdpr function (note - this will be a single object, not an array of objects). You'll still access the consent data with bidderRequest.gdprConsent.
|
Submitted a PR to docs repo - prebid/prebid.github.io#735 |
2 participants
Type of change
Description of change
GDPR support to PulsePoint Bid adapter.
Anand Venkatraman (avenkatraman@pulsepoint.com)