GDPR support for Sovrn Adapter#2475
Merged
mkendall07 merged 29 commits intoprebid:masterfrom May 1, 2018
Merged
Conversation
send 'iv' param if present and full url in `site.page`
Enhance location detection within utils
CR for enhanced-location-detection PR
Reorg gettopwindowlocation util & add tests.
set creativeId to crid if present in response
mkendall07
approved these changes
May 1, 2018
Contributor
mkendall07
left a comment
mkendall07
left a comment
There was a problem hiding this comment.
LGTM, see the comment about NaN value though.
| if (bidderRequest && bidderRequest.gdprConsent) { | ||
| sovrnBidReq.regs = { | ||
| ext: { | ||
| gdpr: +bidderRequest.gdprConsent.gdprApplies |
Contributor
There was a problem hiding this comment.
head's up - if gdprApplies is undefined you'll get NaN here.
Contributor
Author
There was a problem hiding this comment.
The JSON.stringify underneath converts NaN to null. I checked the JSON deserialization and the nulls get handled as if they weren't there. So.. I think we're good. Thanks for pointing out though. I appreciate it.
Contributor
Author
|
We are g2g whenever |
Contributor
|
@rachelrj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
feature
Description of change
gdpr support