Pet 239 ias bid adapter bug fix for multiple slots#2653
Merged
snapwich merged 4 commits intoprebid:masterfrom Jul 9, 2018
Merged
Conversation
* PET-239 Fix. Performs the request for multiple slots on 1 call. * PET-239 Fixed Prebid tests
Contributor
Author
|
Anyway to kick this build off again? Understand the failure or the reason behind the failure? |
Contributor
|
restarted. |
snapwich
requested changes
Jun 7, 2018
modules/iasBidAdapter.js
Outdated
| bidResponses.push(otherResponse); | ||
| }); | ||
|
|
||
| if (top.postIASResponse) { |
Collaborator
There was a problem hiding this comment.
This has the possibility of throwing an exception if within an unfriendly iFrame. Should wrap with try/catch
Contributor
Author
There was a problem hiding this comment.
looking (comment to make sure this PR stays open)
* Fixed errors for PR 2653 * Removed unnecessary block from iasBidAdapter from the comments in pull 2653
Contributor
Author
|
@snapwich: please take another look at the PR. |
Contributor
Author
|
@snapwich: any chance you can take a look at the PR changes? |
Contributor
Author
|
@mkendall07, @snapwich: is there someone else that can take a look? |
snapwich
approved these changes
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
PET-239 Fix: