GDPR consent management for madvertise bidder adapter#2655
GDPR consent management for madvertise bidder adapter#2655jsnellbaker merged 9 commits intoprebid:masterfrom
Conversation
remove aliases
use parseSizesInput method
# Conflicts: # modules/madvertiseBidAdapter.js # test/spec/modules/madvertiseBidAdapter_spec.js
jsnellbaker
left a comment
jsnellbaker
left a comment
There was a problem hiding this comment.
Hi @NLopezMad I took a look through the changes and they seem mostly good.
There are two points on the setup I saw in the spec file that aren't correct, but they're not breaking anything (since you kept the values consistent).
The code in the adapter file is working properly based on my testing.
I'm going to approve this PR, but I'm not going to merge it yet in case you want to update the spec file. I will ensure to merge it though before the next release so it gets included.
| beforeEach(function () { | ||
| let mockConfig = { | ||
| consentManagement: { | ||
| cmpApi: 'IAB', |
There was a problem hiding this comment.
As a note more-so - the value will be iab instead of IAB.
| consentManagement: { | ||
| cmpApi: 'IAB', | ||
| timeout: 1111, | ||
| allowAuctionWithoutConsent: 'cancel' |
There was a problem hiding this comment.
Related to above, this should be a boolean value (false in this case) not the string cancel. Passing in a string here actually causes the config to the opposite value (ie true) which allows the auction to proceed without consent.
4 participants
Type of change
Description of change
Add GDPR consent management to madvertise bidder adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Add GDPR support variable to madvertise bidder adapter doc prebid.github.io#810
Other information