Skip to content

New Adapter ZEDO#2872

Merged
snapwich merged 11 commits intoprebid:masterfrom
skazedo:master
Jul 23, 2018
Merged

New Adapter ZEDO#2872
snapwich merged 11 commits intoprebid:masterfrom
skazedo:master

Conversation

@skazedo
Copy link
Contributor

@skazedo skazedo commented Jul 20, 2018

Type of change

  • Bugfix
  • Feature
  • [X ] New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'zedo',
  params: {
    code: 2264004118
    dimId: 9
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks okay, but it's missing code to handle the GDPR string for the auction request and syncs.

@skazedo
Copy link
Contributor Author

skazedo commented Jul 23, 2018

@snapwich, I have commited changes to pass the gdpr consent in the request and sync .

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 8eedfc3 into prebid:master Jul 23, 2018
mkendall07 added a commit that referenced this pull request Jul 24, 2018
snapwich pushed a commit that referenced this pull request Jul 24, 2018
* Revert "New Adapter ZEDO (#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (#2865)"

This reverts commit f5170d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments