Skip to content

Telaria Bid Adapter#2924

Merged
jaiminpanchal27 merged 13 commits intoprebid:masterfrom
telariaEng:master
Aug 6, 2018
Merged

Telaria Bid Adapter#2924
jaiminpanchal27 merged 13 commits intoprebid:masterfrom
telariaEng:master

Conversation

@telariaEng
Copy link
Contributor

@telariaEng telariaEng commented Aug 1, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

We renamed ourselves to Telaria from Tremor Video after the company split. This is the prebid 1.* adapter for Telaria.

  • test parameters for validating bids
{
  bidder: 'telaria',
  params: {
      supplyCode: 'ssp-demo-rm6rh',
      adCode: 'ssp-!demo!-lufip'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

@mkendall07
Copy link
Contributor

mkendall07 commented Aug 1, 2018

@telariaEng
You might need to rebase off latest master to fix those circle linting errors.

Edit: Yes I'm sure that's the issue, your fork is very behind master:

511 commits behind prebid:master.

@telariaEng
Copy link
Contributor Author

@mkendall07 thanks, yeah did that just now.

…'t always have the crid, so using a sentinel value when we don't have the crid.
@bretg
Copy link
Contributor

bretg commented Aug 2, 2018

Doc PR at prebid/prebid.github.io#912

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is LGTM. Just one minor change is required.
Also this PR should not update package-lock file.

}
return syncs;
},
onTimeout: function (timeoutData) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is optional, you can remove if not using.

- Removed the package-lock file.
# Conflicts:
#	package-lock.json
@telariaEng
Copy link
Contributor Author

@jaiminpanchal27 thanks, I removed the unused method and discarded the package-lock changes.

@jaiminpanchal27 jaiminpanchal27 merged commit d303d1d into prebid:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments