Merged
Conversation
…. Also updated certain param names used in the test spec.
…g the CircleCI tests to fail.
Contributor
|
@telariaEng Edit: Yes I'm sure that's the issue, your fork is very behind master:
|
Contributor
Author
|
@mkendall07 thanks, yeah did that just now. |
…'t always have the crid, so using a sentinel value when we don't have the crid.
Contributor
|
Doc PR at prebid/prebid.github.io#912 |
jaiminpanchal27
requested changes
Aug 3, 2018
Collaborator
jaiminpanchal27
left a comment
There was a problem hiding this comment.
Code is LGTM. Just one minor change is required.
Also this PR should not update package-lock file.
modules/telariaBidAdapter.js
Outdated
| } | ||
| return syncs; | ||
| }, | ||
| onTimeout: function (timeoutData) { |
Collaborator
There was a problem hiding this comment.
This function is optional, you can remove if not using.
- Removed the package-lock file.
# Conflicts: # package-lock.json
Contributor
Author
|
@jaiminpanchal27 thanks, I removed the unused method and discarded the package-lock changes. |
jaiminpanchal27
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We renamed ourselves to Telaria from Tremor Video after the company split. This is the prebid 1.* adapter for Telaria.
Be sure to test the integration with your adserver using the Hello World sample page.