Skip to content

PROPS IPAX - GIANTS Adapter#2933

Merged
snapwich merged 4 commits intoprebid:masterfrom
PROPS-IPAX:master
Aug 7, 2018
Merged

PROPS IPAX - GIANTS Adapter#2933
snapwich merged 4 commits intoprebid:masterfrom
PROPS-IPAX:master

Conversation

@PROPSIPAX
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'giants',
  params: {
    'zoneId': '584072408' // id provided by PROPS IPAX
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: support@props.id
  • official adapter submission

newline end file
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change with the alias.

Also this code is missing handling of the gdpr string for both the bid requests and the user sync request.


export const spec = {
code: BIDDER_CODE,
aliases: ['giants'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed. The adapter is already called the giants adapter, so this alias is a duplicate.

@PROPSIPAX
Copy link
Contributor Author

We removed alias and added GDPR.
Please check for me, thanks.

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 752e234 into prebid:master Aug 7, 2018
@PROPSIPAX
Copy link
Contributor Author

Please let me know what I need to do next so my adapter can be updated to the adapter list on prebid.org.

@snapwich
Copy link
Collaborator

snapwich commented Aug 8, 2018

@PROPSIPAX

to get on the download page you need to submit a bidders md file as outlined here: https://github.com/prebid/prebid.github.io#the-downloads-page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments