Merged
Conversation
newline end file
snapwich
requested changes
Aug 6, 2018
Collaborator
snapwich
left a comment
There was a problem hiding this comment.
One small change with the alias.
Also this code is missing handling of the gdpr string for both the bid requests and the user sync request.
modules/giantsBidAdapter.js
Outdated
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['giants'], |
Collaborator
There was a problem hiding this comment.
This is not needed. The adapter is already called the giants adapter, so this alias is a duplicate.
Contributor
Author
|
We removed alias and added GDPR. |
Contributor
Author
|
Please let me know what I need to do next so my adapter can be updated to the adapter list on prebid.org. |
Collaborator
|
to get on the download page you need to submit a bidders md file as outlined here: https://github.com/prebid/prebid.github.io#the-downloads-page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.