Skip to content

Fidelity Media fmxSSP. Adding GDPR Support#2935

Merged
jaiminpanchal27 merged 3 commits intoprebid:masterfrom
onaydenov:master
Aug 13, 2018
Merged

Fidelity Media fmxSSP. Adding GDPR Support#2935
jaiminpanchal27 merged 3 commits intoprebid:masterfrom
onaydenov:master

Conversation

@onaydenov
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Fidelity Media fmxSSP. Adding GDPR Support

  • test parameters for validating bids
{
  bidder: 'fidelity',
  params: {
    zoneid: '27248',
    floor: 0.01,
    server: 'x.fidelity-media.com'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

var gdpr = 0;
var consent_str = '';
var consent_given = 0;
if (typeof gdprConsent.gdprApplies !== 'undefined') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this duplicate logic in one function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. We are making necessary changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiminpanchal27 Changes were made, please review.

@jaiminpanchal27 jaiminpanchal27 merged commit bd60750 into prebid:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments