Merged
Conversation
…d cookie browser support
…ow to handle both 'value' and 'storage' existing in config
…inition in function arguments
…bmodules and configs
…nt of refactoring/formatting cleanup
… add test for one storage type active with only one module configured to use that type
…ook due to necessary use of prebid global object affecting following tests
…ows watching the first element added to add the bid request hook
…red value does not exist
…invalid config storage type, revised commenting
…project/Prebid.js into add-user-id-module
Closed
1 task
added 9 commits
April 3, 2019 13:54
…ror on cirlceci for the Safari Browsers
Contributor
|
@pycnvr , @jsnellbaker , @snapwich - hoping to release this next week with 2.10. I believe Isaac's updated it with the inspection requests except for some features that I propose we hash out in a separate thread. |
jsnellbaker
approved these changes
Apr 4, 2019
pycnvr
approved these changes
Apr 4, 2019
Collaborator
|
Looks good. |
Contributor
|
@idettman Should this be using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User ID Module
Type of change
Description of change
This module adds a User ID module, which currently includes submodules for Unified ID and Pub Common ID.
Submodule Configuration
Each submodule can configure how it stores user id data to the the browser.
type: sets the browser storage API used to store the user data. The supported types are
html5, orcookiehtml5useswindow.localStoragecookieusesdocument.cookiesexpires: days to expire to locally stored values
name: the name of the key used to store user data
Example