LiveYield Analytics Adapter

[tomek-jedro]

Type of change

• New analytics adapter

Description of change

New PubOcean LiveYield Analytics adapter.

• test parameters for validating the adapter:

{
  provider: 'liveyield',
  options: {
    customerId: 'b4c106a4-a8cb-4321-a9d2-aec3cde2e64e',
    customerName: 'Prebid Test',
    customerSite: 'prebid-test.com',
    sessionTimezoneOffset: '-300'
  }
}

• contact email of the adapter’s maintainer: liveyield@pubocean.com
• official adapter submission

[jsnellbaker]

Hi @tomek-jedro

I have some questions about some of the functions (see below); otherwise this overall looks good.

[jsnellbaker]

Is there more to be done here? The comment refers to a mapping of values, but this function just returns the argument variable.

If this setup is intended, could you clarify more about why this is needed and/or what this is adding?

[tomek-jedro]

this function should be overridden by customer

[jsnellbaker]

In that case - it may ideal to either surround the function calls in a try/catch block or validate the overridden functions set in the config.options to handle any accidental setups.

[jsnellbaker]

Could you expand upon the intended logic here?

Currently version comes in as a string like 1.37.0. So the version[1] would always equal a . character and cause the logic check to return the false value. Do you have a scenario/use-case where the true value of this expression would be returned?

[tomek-jedro]

this will be fixed, that function should check for the first element

[tomek-jedro]

@jsnellbaker can you check it? everything should be fine, im happy to help

[jsnellbaker]

@tomek-jedro Thanks for making the recent requested updates. There is one more set of changes needed (due in part to something that was committed semi-recently).

Please take a look at the note below. We should be good to merge after this change is made.

[jsnellbaker]

Due to a recent merge (see #3435), we now require any imports for a core or modules file (like this Analytics adapter file) to use a relative path style.

Additionally, the name of the file adaptermanager was changed to adapterManager in master (you may need to rebase with master for your branch to accept this type of change).

Can you please update these imports here?

[jsnellbaker]

@tomek-jedro Thanks for making these additional updates. Everything looks good now.