Skip to content

adding yieldbot adapter#35

Merged
mkendall07 merged 1 commit intoprebid:masterfrom
asharpinc:yieldbot-adapter
Aug 31, 2015
Merged

adding yieldbot adapter#35
mkendall07 merged 1 commit intoprebid:masterfrom
asharpinc:yieldbot-adapter

Conversation

@nickjacob
Copy link
Collaborator

#5 - set this up as a basic integration, using yieldbot.getSlotCriteria

  • quick patch to issue with rubicon adapter + some page timings (pbjs not defined)
  • added params to gpt example; can PR separately in docs repo for docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Could you refactor this into the first line of src/prebid.js - since this is an issue with pbjs being undefined other adapters could also have this issue. Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I'll take this out of here and put in a separate PR for that

@ialex
Copy link
Contributor

ialex commented Aug 31, 2015

To integrate this, will we have to use the yieldbot line items in the configuration? or is it going to reuse the ones prebid uses for some of his adapters?

@nickjacob
Copy link
Collaborator Author

@ialex this uses the standard prebid line items/the hb_* targeting key-values so it shouldn't require any changes on the ad-ops/ad-server side

mkendall07 added a commit that referenced this pull request Aug 31, 2015
@mkendall07 mkendall07 merged commit 1044143 into prebid:master Aug 31, 2015
marian-r added a commit to aol/Prebid.js that referenced this pull request Nov 2, 2016
…MP-73-false-timed-out-bids to release/1.3.1

* commit '07315b6725a442dd26ee748174cd018949c05010':
  Refactoring, code cleanup
  Fixed reporting of timed out bids in AOL analytics
ChrisHuie pushed a commit that referenced this pull request Dec 5, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

* update minuteMediaBidAdapter - support missing params (#29)

* RIseBidAdapter: support currency (#35)

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments