Rubicon BidAdapter - SRA support for >10 bids#3514
Merged
idettman merged 3 commits intoprebid:masterfrom Apr 18, 2019
Merged
Conversation
robertrmartinez
approved these changes
Feb 7, 2019
harpere
reviewed
Feb 11, 2019
Collaborator
harpere
left a comment
harpere
left a comment
There was a problem hiding this comment.
LGTM, but want to test before merging.
| */ | ||
| function partitionArray(array, size) { | ||
| return array.map((e, i) => (i % size === 0) ? array.slice(i, i + size) : null).filter((e) => e) | ||
| } |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
harpere
approved these changes
Apr 18, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* added support to use multiple requests for SRA requests with more than 10 bids * updated unit test to test SRA dividing 100 bids into 10 requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rubicon Bid Adapter - SRA support for more than 10 bids
Type of change
Description of change
The Ad Engine can handle a maximum of 10 sub-requests (slots/adUnits) per SRA request. As a simplification and to speed up development, we decided that the adapter would include only the first 10 adUnits in an SRA request and ignore the rest. This may be an edge case, but it is sub-optimal. Instead of ignoring them we should create a new SRA request for these adUnits.
Other information