Merged
Conversation
src/adapters/sekindo.js
Outdated
| } | ||
| else | ||
| { | ||
| utils.logMessage('No prebid response for placement %%PLACEMENT%%'); |
Contributor
There was a problem hiding this comment.
You need to replace %%PLACEMENT%% with the actual placement name here
Collaborator
|
I'm getting ad payloads back but not seeing CPMs higher than 0. Is that expected when using test params? |
Contributor
|
@sekindo |
src/adapters/sekindo.js
Outdated
|
|
||
| pbjs.sekindoCB = function(callbackId, response) | ||
| { | ||
| if (typeof (response) != 'undefined' && typeof (response.cpm) != 'undefined') |
Contributor
There was a problem hiding this comment.
please use triple equality.
Contributor
Author
|
Hi,
Thx |
Contributor
|
Thanks. Please update |
Contributor
Author
|
logging - fixed |
Collaborator
|
Thanks for the fixes, confirmed bids back and ads rendered, tests passing, reviewed. |
protonate
pushed a commit
that referenced
this pull request
Jun 15, 2016
* Sekindo Prebid Adaptor : * add placement id to error log * append iframe to head * refactor * use triple equality & adding sekindo to package.json * logging * frameDoc.open()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new Sekindo Adapter:
We red the latests pusg requests reviews and applied them (such as use only https, not use bidmanager.setExpectedBidsCount and few more)
Thanks,
Sekindo dev team