modules: Implement SmartRTB adapter and spec.

[evanmsmrtb]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Addition of SmartRTB / smrtb.com prebid module.

• test parameters for validating bids

{
  bidder: 'smartrtb',
  params: {
    pubId: 123,
    medId: "m_123",
    zoneId": "z_abc"
  }
}

• contact email of the adapter’s maintainer
• [ engineering@smrtb.com] official adapter submission

[jsnellbaker]

@evanmsmrtb

Thanks for submitting this new adapter.

There was one point of feedback on the code, please take a look when you have the chance.

While trying to test the adapter with the params in the description, I wasn't getting any object response from the server; the call to http://pubs.smrtb.com/json/publisher/prebid completed with a 204 OK.

Below is a copy of the request object that was executed, can you take a look to see if anything is amiss?

{"start_time":1551126396115,"tmax":120,"language":"en-US","site":{"domain":"ap.localhost","iframe":false,"url":null,"https":false,"referrer":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"imps":[{"pub_id":123,"med_id":"m_123","zone_id":"z_abc","bid_id":"2ae840036721c5","imp_id":"75fd1f36-d614-4105-bb11-1ebf93de10ec","sizes":[[300,250],[300,600]]}]}

[jsnellbaker]

Found an additional item that needs to be updated.

[evanmsmrtb]

@jsnellbaker Fixed the for-loop syntax for IE and internalized getDomain(). Please verify.

[jsnellbaker]

@evanmsmrtb Thanks for making the code updates; those look fine now.

Did you have the chance to look at the issue with test bid not returning? I'm seeing that problem when using the test params on the hello_world.html page.

[evanmsmrtb]

Yes, this has now been corrected. You should see sample bids returned with these parameters:

{
            bidder: "smartrtb",
            params: {
                pubId: 123, 
                medId: "m_00a95d003340dbb2fcb8ee668a84fa",
                zoneId: "z_261b6c7e7d4d4985393b293cc903d1"
            }
 }

[evanmsmrtb]

@jsnellbaker Please review updated params and for-loop syntax.

[jsnellbaker]

@evanmsmrtb I apologize for the delay; the code changes do look fine. But I tested with the parameters in the previous comment, but I'm still not getting a response from the server.

The status of the request is (canceled). Below is a copy of the URL and its payload:
http://pubs.smrtb.com/json/publisher/prebid

{"start_time":1551804908474,"tmax":120,"language":"en-US","site":{"domain":"test.localhost","iframe":false,"url":null,"https":false,"referrer":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"},"imps":[{"pub_id":123,"med_id":"m_00a95d003340dbb2fcb8ee668a84fa","zone_id":"z_261b6c7e7d4d4985393b293cc903d1","bid_id":"2ccb22d862625f","imp_id":"a61e88a9-d31e-41e9-8fa1-63c775e1852f","sizes":[[300,250]]}]}

Do you see anything incorrect or unexpected in the above?

[evanmsmrtb]

@jsnellbaker No problem. It appears you caught us while we were working on parts of our API. Please try again - I have confirmed it is up again and returning bids.

[jsnellbaker]

@evanmsmrtb I tried again but it's not connecting. I setup a test variant where I disabled the internal timeouts for the auction and on our ajax request to allow the server ample time to respond. However it just resulted in a 522 Origin Connection Time-out error.

I attached a screenshot of the request details/headers/payload from this test. Could the issue with the alias I have setup to run the local server? Are you doing something on the server when any variant of localhost is included for instance?

[evanmsmrtb]

@jsnellbaker We located and fixed what was causing this. Please try again - third time's the charm.

[jsnellbaker]

@evanmsmrtb Thanks for digging into this. I tried again and verified the ad is delivering successfully.

LGTM